Ahmed Abdelmotteleb requested to merge ahabdelm-remove-gec-from-hlt1 into master Jan 30, 2023

Renders !664 (closed) and !784 (closed) obsolete

Test with Moore!2631 (merged) and MooreOnline!278 (merged)

Want to remove Global Event Cuts (GEC) from the default HLT1 sequence. All HLT1 would then run without these cuts being implemented at the beginning of data processing.

Also want to study the impact on the selection efficiency for Z\rightarrow\mu\mu, W\rightarrow\mu\nu, and other processes impacted by the GEC

Changes:

Set the default hlt1 node to NOT include GEC (EnableGEC=False in HLT1.py)
Remove GEC from all sequence files in configuration/python/AllenSequences
Allow GEC to be configurable in validator_node function

- Added a new function called make_composite_node to replace the currrently used function make_composite_node_with_gec which is featured in a couple of sequence files (is there a better way to do this?) -->Unnecessary

Next plans:

Study the impact on the selection efficiency for Z\rightarrow\mu\mu
Study the impact on the selection efficiency for W\rightarrow\mu\nu
Confirm that the impact on the throughput is reasonable
Remove all instances where we use GECs (except one sequence hlt1_pp_default_gec)
Adjust throughput tests to run over correct sequences (now without GECs by default)

Throughput:

Latest throughput values obtained from the "AllenPR throughput" mattermost channel:

TL;DR: all throughputs are fine, apart from the one from hlt1_pp_no_ut which is slightly worse than before:

hlt1_pp_default --> with GECs:
hlt1_pp_no_gec --> without GECs:
hlt1_pp_matching --> with GECs:
hlt1_pp_matching_no_gec --> without GECs and without ut:
hlt1_pp_no_ut --> without GECs:

Efficiencies:

Studied the efficiencies for Z/W decays using HltEfficiencyChecker and 2 yaml files: hlt1_z_eff.yaml hlt1_w_eff.yaml

Can just run the command: MooreAnalysis/run MooreAnalysis/HltEfficiencyChecker/scripts/hlt_eff_checker.py hlt1_w_eff.yaml from the stack home directory

TL;DR: both W and Z efficiencies increase without GEC as expected (0.914 --> 0.941 and 0.935 --> 0.977 respectively)

W before (master branch): w_eff_check_master_branch.txt

Integrated HLT efficiencies for the lines with denominator: CanRecoChildren
------------------------------------------------------------------------------------
Line:	 Hlt1SingleHighPtMuonDecision         	 Efficiency:	 0.914 +/- 0.009
Line:	 W_Hlt1SingleHighPtMuonDecisionTrueSim	 Efficiency:	 0.914 +/- 0.009
------------------------------------------------------------------------------------
Finished printing integrated HLT efficiencies for denominator: CanRecoChildren
------------------------------------------------------------------------------------

W after (this branch): w_eff_check_new_branch.txt

Integrated HLT efficiencies for the lines with denominator: CanRecoChildren
------------------------------------------------------------------------------------
Line:	 Hlt1SingleHighPtMuonDecision         	 Efficiency:	 0.941 +/- 0.008
Line:	 W_Hlt1SingleHighPtMuonDecisionTrueSim	 Efficiency:	 0.940 +/- 0.008
------------------------------------------------------------------------------------
Finished printing integrated HLT efficiencies for denominator: CanRecoChildren
------------------------------------------------------------------------------------

Z before (master branch): z_eff_check_master_branch.txt

Integrated HLT efficiencies for the lines with denominator: CanRecoChildren
------------------------------------------------------------------------------------
Line:	 Hlt1SingleHighPtMuonDecision          	 Efficiency:	 0.935 +/- 0.015
Line:	 Z0_Hlt1SingleHighPtMuonDecisionTrueSim	 Efficiency:	 0.935 +/- 0.015
------------------------------------------------------------------------------------
Finished printing integrated HLT efficiencies for denominator: CanRecoChildren
------------------------------------------------------------------------------------

Z after (this branch): z_eff_check_new_branch.txt

Integrated HLT efficiencies for the lines with denominator: CanRecoChildren
------------------------------------------------------------------------------------
Line:	 Hlt1SingleHighPtMuonDecision          	 Efficiency:	 0.977 +/- 0.009
Line:	 Z0_Hlt1SingleHighPtMuonDecisionTrueSim	 Efficiency:	 0.977 +/- 0.009
------------------------------------------------------------------------------------
Finished printing integrated HLT efficiencies for denominator: CanRecoChildren
------------------------------------------------------------------------------------

I also checked with the default HLTEfficiencyChecker example: MooreAnalysis/run MooreAnalysis/HltEfficiencyChecker/scripts/hlt_eff_checker.py MooreAnalysis/HltEfficiencyChecker/options/hlt1_eff_example.yaml and confirmed that these lines were not affected (as expected): default_eff_check_master_branch.txt default_eff_check_new_branch.txt