Skip to content
Snippets Groups Projects

WIP: first attempt to persistify the new CaloReco data from the stripping in the (m)DST

Closed Ricardo Vazquez Gomez requested to merge new-CaloRecoInDST into master
1 unresolved thread

Store in the DST the CaloClusters, CaloADCs, and CaloDigits in the (m)DST for calo calibration.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
686 714 AlwaysCreateOutput = False,
687 715 DeleteInput = False,
688 716 InputName = self.branch + "/MC/Particles",
689 # Pack to LHCb::PackedMCParticleLocation::Default
690 OutputName = self.branch + "/pSim/MCParticles" ),
717 OutputName = self.branch + "/pMC/Particles" ),
  • I'll provide asap (hopefully by friday) the missing packers for CaloDigits and CaloADCs.

  • OK, it's a little painful to get the packers so late as we have already released the patch to LHCb where they should belong. @erodrigu I guess you will have to include them temporarily in the DaVinci patch directly, until we release another 2017-patches full stack....

  • yes, I thought the CaloXXX containers could be persistified as they are. I missed that additional packers were needed. I'll do that as soon as possible. CaloDigits and CaloADCs are simple objects and I hope I can have something quickly

  • Olivier, then remove the "WIP" when you are ready so that the commits get checked in the nightlies ... This will then have to be cherry-picked in DaVinci ...

  • Aside the issue in a line, which Marco already raised: this MR is meant in the 2017-patches for Phys, not master! Once in a while the branch then gets merged into the master ... I've just done that this week, actually.

  • Just pinging. I'm ready to tag the patch release modulo this MR. Do not forget the one correction from Marco above …

  • In fact I'm going to tag DaVinci as there is a little thing worrying me in the nightlies. I will then retag with this MR in.

  • Eduardo, don't forget that you'll also have to put in this DaVinci release the patched version of CaloTools following MR Rec!615 (merged) (and remove it for the following release when we make a new 2017-patches stack release...

  • Hi Marco, you do well in reminding me. I cannot remember being made aware of this. So thank you.

  • OK, picked Calo/CaloTools from Rec!615 (merged). Thanks.

  • mentioned in merge request LHCb!728 (merged)

  • Please note I just made some comments on how this should be set up in LHCb!728 (merged)

  • I have recommitted to 2017-patches, so will close this MR.

  • Eduardo Rodrigues mentioned in merge request !137 (merged)

    mentioned in merge request !137 (merged)

  • Please register or sign in to reply
    Loading