Include the SSPion/SSProton fix into the latest FT development

This MR introduces the SSPion/SSProton fix into FlavourTagging's gitlab-ci branch. This essentially turns the failing pipeline into a successful one, meaning that all taggers passed the "first line of defence" tests.

We still need to discuss an internal tag flip inside the SSKaonLatest tagger, which prevents TAGETAS > 0.5, but potentially changes the SSKaonLatest TAGETA distribution.

Ping @mschille @sakar

@kheinick @mschille @sakar Could you please let us know when all FT issues are resolved and when we can proceed with 2017-patches? Thank you. FYI @erodrigu

H. Thanks for cc'ing me. This is getting urgent as we need to finish with the new patch release on 2017-patches. Many people are waiting for the release. Note also that I'm off on holidays this Sunday!

Hi, sorry for the delay. Of course we'll let you know. We just have one outstanding point that we need to finish evaluating, and we'll be ready.

Thanks, what's the timescale here?

May I propose we merge the fix in 2017-patches, and you continue your checks in parallel?

The benefits are that at least we don't delay 2017 MC (for which a buggy FT doesn't matter, as the new DaVinci will only be used in the Tesla step) and that we don't release a version that is known to be broken.

@kheinick @mschille @sakar If you agree, could we please do a cherry-pick of the minimal fix to 2017-patches, which we can merge now? We can think if/how we can integrate the CI later.

We just discussed this at the PAC meeting and it seems best. Please do create the MR to 2017-patches asap (keep in mind I'm off for holidays this weekend). Thanks.

Hi @erodrigu @rmatev, I will prepare the minimal MR for the SSPion/SSProton taggers.

Apart from that there are two MRs that did not end up in 2017-patches yet (!346 (merged) and !366 (merged)). These have already been merged to 2018-patches, run2-patches and master and essentially set up the nominal Run 2 Flavour Tagging tuning, therefore I suppose you would like to have them in 2017-patches now as well. I will prepare the cherry-picks if you wish.

Hmm, this is all coming rather late! Fingers crossed the builds will be OK. Go ahead and create it all. WE will see tomorrow if all is fine. Thanks.

For completeness: see !402 (merged) for the equivalent of this MR to 2017-patches directly, cf. the discussion above.

merged

mentioned in commit ea175d02