Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • Phys Phys
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Jira
    • Jira
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • PhysPhys
  • Merge requests
  • !928

Change interfaces to make geometry always explicit

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Sebastien Ponce requested to merge sponce_explicitGeometry into master Apr 28, 2021
  • Overview 26
  • Commits 23
  • Pipelines 65
  • Changes 255

Goes along with LHCb!3019 (merged), Rec!2411 (merged), Moore!869 (merged), Analysis!794 (merged), Castelao!106 (merged), Alignment!185 (merged) and Panoramix!96 (merged)

Most interfaces using geometry were not passing it explicitly, relying on low level globals and caches to find out the right one by magic.

This is no more possible for at least 2 reasons :

  • in multi-threading mode, several geometries may be in flight concurrently
  • DD4hep requires explicit geometry passing

On the way, a fair amount of code refactoring was made, including :

  • merging of .h into .cpp when possible
  • cleaning up of unneeded code (e.g. many empty destructors)
  • sorting out includes
Edited Jun 18, 2021 by Sebastien Ponce
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: sponce_explicitGeometry