Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • R Rec
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 280
    • Issues 280
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 50
    • Merge requests 50
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • Rec
  • Merge requests
  • !2411

Change interfaces to make geometry always explicit

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Sebastien Ponce requested to merge sponce_explicitGeometry into master Apr 22, 2021
  • Overview 22
  • Commits 20
  • Pipelines 50
  • Changes 160

Goes along with LHCb!3019 (merged), Phys!928 (merged), Moore!869 (merged), Analysis!794 (merged), Castelao!106 (merged), Alignment!185 (merged) and Panoramix!96 (merged)

Most interfaces using geometry were not passing it explicitely, relying on low level globals and caches to find out the right one by magic.

This is no more possible for at least 2 reasons :

  • in multi-threading mode, several geometries may be in flight concurrently
  • DD4hep requires explicit geometry passing

On the way, a fair amount of code refactoring was made, including :

  • merging of .h into .cpp when possible
  • cleaning up of unneeded code (e.g. many empty destructors)
  • sorting out includes
Edited Jun 18, 2021 by Sebastien Ponce
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: sponce_explicitGeometry