LongLivedTracking cleanup, optimisation and adaptation to Pr::Tracks (!2222) · Merge requests · LHCb / Rec

Arthur Marius Hennequin requested to merge ahennequ_longlived into master Oct 03, 2020

This MR contains a lot of changes, mainly due to moving things around, might be better to look at the individual commits.

The main goal is to adapt input and output to Pr::Tracks when !2208 (merged) and LHCb!2733 (merged) are merged.

To simplify the process of adaptation, some cleaning had to be done (dead code removal, only give to functions what is used, remove unnecessary allocations, simplify logic). I also found and fixed some minor bugs.

Goes with LHCb!2801 (merged) and Moore!635 (merged)

Improved efficiencies and ghost rate (1k evts Bs->PhiPhi):

Before:

DownstreamTrackChecker                 INFO **** Downstream                     78919 tracks including          23298 ghosts [29.52 %], Event average 27.32 % ****
DownstreamTrackChecker                 INFO   01_UT+T                       :   49503 from    64785 [ 76.41 %]      0 clones [ 0.00 %], purity: 99.44 %, hitEff: 99.23 %
DownstreamTrackChecker                 INFO   02_UT+T_P>5GeV                :   33310 from    38967 [ 85.48 %]      0 clones [ 0.00 %], purity: 99.42 %, hitEff: 99.30 %
DownstreamTrackChecker                 INFO   03_UT+T_strange               :    3600 from     5210 [ 69.10 %]      0 clones [ 0.00 %], purity: 99.43 %, hitEff: 98.98 %
DownstreamTrackChecker                 INFO   04_UT+T_strange_P>5GeV        :    2073 from     2626 [ 78.94 %]      0 clones [ 0.00 %], purity: 99.46 %, hitEff: 99.30 %
DownstreamTrackChecker                 INFO   05_noVelo+UT+T_strange        :    1668 from     2553 [ 65.33 %]      0 clones [ 0.00 %], purity: 99.48 %, hitEff: 98.93 %
DownstreamTrackChecker                 INFO   06_noVelo+UT+T_strange_P>5GeV :    1042 from     1403 [ 74.27 %]      0 clones [ 0.00 %], purity: 99.55 %, hitEff: 99.27 %
DownstreamTrackChecker                 INFO   07_UT+T_fromDB                :    3965 from     4951 [ 80.08 %]      0 clones [ 0.00 %], purity: 99.53 %, hitEff: 99.34 %
DownstreamTrackChecker                 INFO   08_UT+T_fromBD_P>5GeV         :    3227 from     3741 [ 86.26 %]      0 clones [ 0.00 %], purity: 99.54 %, hitEff: 99.47 %
DownstreamTrackChecker                 INFO   09_noVelo+UT+T_fromBD         :     315 from      669 [ 47.09 %]      0 clones [ 0.00 %], purity: 99.43 %, hitEff: 98.75 %
DownstreamTrackChecker                 INFO   10_noVelo+UT+T_fromBD_P>5GeV  :     160 from      291 [ 54.98 %]      0 clones [ 0.00 %], purity: 99.43 %, hitEff: 98.78 %
DownstreamTrackChecker                 INFO   11_UT+T_SfromDB               :     218 from      294 [ 74.15 %]      0 clones [ 0.00 %], purity: 99.53 %, hitEff: 98.78 %
DownstreamTrackChecker                 INFO   12_UT+T_SfromDB_P>5GeV        :     135 from      168 [ 80.36 %]      0 clones [ 0.00 %], purity: 99.63 %, hitEff: 99.30 %
DownstreamTrackChecker                 INFO   13_noVelo+UT+T_SfromDB        :     117 from      162 [ 72.22 %]      0 clones [ 0.00 %], purity: 99.73 %, hitEff: 99.62 %
DownstreamTrackChecker                 INFO   14_noVelo+UT+T_SfromDB_P>5GeV :      74 from       97 [ 76.29 %]      0 clones [ 0.00 %], purity: 99.74 %, hitEff: 99.39 %

After:

DownstreamTrackChecker                 INFO **** Downstream                     75265 tracks including          17480 ghosts [23.22 %], Event average 21.13 % ****
DownstreamTrackChecker                 INFO   01_UT+T                       :   51175 from    64785 [ 78.99 %]      0 clones [ 0.00 %], purity: 99.49 %, hitEff: 99.69 %
DownstreamTrackChecker                 INFO   02_UT+T_P>5GeV                :   33836 from    38967 [ 86.83 %]      0 clones [ 0.00 %], purity: 99.48 %, hitEff: 99.71 %
DownstreamTrackChecker                 INFO   03_UT+T_strange               :    3792 from     5210 [ 72.78 %]      0 clones [ 0.00 %], purity: 99.50 %, hitEff: 99.69 %
DownstreamTrackChecker                 INFO   04_UT+T_strange_P>5GeV        :    2140 from     2626 [ 81.49 %]      0 clones [ 0.00 %], purity: 99.51 %, hitEff: 99.81 %
DownstreamTrackChecker                 INFO   05_noVelo+UT+T_strange        :    1754 from     2553 [ 68.70 %]      0 clones [ 0.00 %], purity: 99.55 %, hitEff: 99.67 %
DownstreamTrackChecker                 INFO   06_noVelo+UT+T_strange_P>5GeV :    1078 from     1403 [ 76.84 %]      0 clones [ 0.00 %], purity: 99.59 %, hitEff: 99.79 %
DownstreamTrackChecker                 INFO   07_UT+T_fromDB                :    4040 from     4951 [ 81.60 %]      0 clones [ 0.00 %], purity: 99.57 %, hitEff: 99.74 %
DownstreamTrackChecker                 INFO   08_UT+T_fromBD_P>5GeV         :    3247 from     3741 [ 86.79 %]      0 clones [ 0.00 %], purity: 99.57 %, hitEff: 99.76 %
DownstreamTrackChecker                 INFO   09_noVelo+UT+T_fromBD         :     329 from      669 [ 49.18 %]      0 clones [ 0.00 %], purity: 99.51 %, hitEff: 99.62 %
DownstreamTrackChecker                 INFO   10_noVelo+UT+T_fromBD_P>5GeV  :     163 from      291 [ 56.01 %]      0 clones [ 0.00 %], purity: 99.49 %, hitEff: 99.69 %
DownstreamTrackChecker                 INFO   11_UT+T_SfromDB               :     228 from      294 [ 77.55 %]      0 clones [ 0.00 %], purity: 99.62 %, hitEff: 99.80 %
DownstreamTrackChecker                 INFO   12_UT+T_SfromDB_P>5GeV        :     138 from      168 [ 82.14 %]      0 clones [ 0.00 %], purity: 99.64 %, hitEff: 99.82 %
DownstreamTrackChecker                 INFO   13_noVelo+UT+T_SfromDB        :     121 from      162 [ 74.69 %]      0 clones [ 0.00 %], purity: 99.74 %, hitEff: 99.79 %
DownstreamTrackChecker                 INFO   14_noVelo+UT+T_SfromDB_P>5GeV :      75 from       97 [ 77.32 %]      0 clones [ 0.00 %], purity: 99.74 %, hitEff: 99.67 %

Bug fixes that improved physics:

@decianm @peilian @chasse @sstahl @sponce

Edited Oct 16, 2020 by Arthur Marius Hennequin

LongLivedTracking cleanup, optimisation and adaptation to Pr::Tracks

Merge request reports