Skip to content

Remove Velo, TT, IT, OT, SPD, PRS

Patrick Koppenburgrequested to merge
pkoppenb-cleanup-Rec into master

Cleanup of obsolete detectors. Build on top of LHCb!2804 (merged). See overall picture at lhcb-dpa/project#18 lhcb-dpa/project#37.

Remove obsolete files

  • Pr/PrFitParams/options/PrFitParams.py
  • Tf/TrackSys/options/DSTRefitting.opts
  • Tf/TrackSys/options/VeloTEDOne.py
  • Tf/TsaAlgorithms/src/STCosmicFilter.cpp
  • Tr/TrackCheckers/options/refit_ntupling.opts
  • Tr/TrackInterfaces/TrackInterfaces/ISTClusterCollector.h, Tr/TrackInterfaces/dict/TrackInterfacesDict.h, Tr/TrackInterfaces/dict/TrackInterfacesDict.xml
  • Tr/TrackMCTools/src/*GhostClassification.* : Some may need to be restored.
  • Tr/TrackMonitors/src/PVSplit.cpp : may need to be rewritten for VP
  • Tr/TrackMonitors/src/ST*,
  • Tr/TrackTools/src/ITTrackConfirmation.*
  • Tr/TrackTools/src/STClusterCollector.*
  • Tr/TrackTools/src/TTHitExpectation.*
  • Tr/TrackUtils/src/HltTrackConverter.cpp
  • Tr/TrackUtils/src/TTrackFromLong.cpp
  • Tr/TrackUtils/src/TrackPrepareForFit.cpp
  • Tr/TrackUtils/src/TrackPrepareVelo.cpp

Remove dependencies on obsolete detectors

  • Pr/PrAlgorithms/CMakeLists.txt
  • Pr/PrMCTools/CMakeLists.txt
  • Pr/PrMCTools/src/PrDebugTrackingLosses.cpp : dependency on velo, TT, IT
  • Pr/PrMCTools/src/PrTStationDebugTool.cpp : dependency on OT
  • Rec/ChargedProtoANNPID/src/ChargedProtoANNPIDCommonBase.icpp: remove some number of clusters
  • Rec/GlobalRecoMCTools/CMakeLists.txt
  • Rec/LoKiTrack/LoKi/Track.h: IT or OT -> FT
  • Rec/LoKiTrack/LoKi/TrackIDs.h, Rec/LoKiTrack/src/TrackIDs.cpp : global replace of detector names. Needs a revision.
  • Rec/RecAlgs/src/RecSummaryAlg.cpp : Velo -> VP
  • Rec/RecAlgs/src/TimingTuple.cpp: Cluster names
  • Tf/TfKernel/CMakeLists.txt
  • Tf/TfKernel/TfKernel/RegionID.h: removed includes. Doesn't seem to matter.
  • Tf/TsaKernel/CMakeLists.txt
  • Tr/PatChecker/src/PrimaryVertexChecker.cpp : dependency of DeVelo removed
  • Tr/PatPV/CMakeLists.txt
  • Tr/PatPV/src/PVOfflineTool.cpp : Velo -> VP
  • Tr/TrackAssociators/src/TrackAssociator.* : detectors renamed
  • Tr/TrackCheckers/src/TrackEffChecker.cpp : detectors renamed
  • Tr/TrackCheckers/src/TrackIPResolutionCheckerNT.cpp : locations changed
  • Tr/TrackFitEvent/CMakeLists.txt
  • Tr/TrackKernel/TrackKernel/TrackCloneData.h : rename detectors
  • Tr/TrackMCTools/CMakeLists.txt
  • Tr/TrackMCTools/src/LHCbIDsToMCHits.*, Tr/TrackMCTools/src/LHCbIDsToMCParticles.* : rename detectors
  • Tr/TrackMonitors/CMakeLists.txt
  • Tr/TrackMonitors/src/PVResMonitor.cpp : remove dependency on DeVelo
  • Tr/TrackMonitors/src/TrackVertexMonitor.cpp : needs revision
  • Tr/TrackMonitors/src/UTTrackMonitor.cpp : minor variable name change
  • Tr/TrackMonitors/src/VertexCompare.cpp : remove dependency on DeVelo
  • Tr/TrackMonitors/src/TrackFitMatchMonitor.cpp : rename TT to UT in variable names
  • Tr/TrackMonitors/src/BeamGasVertexMonitor.cpp : velo -> vp. A pointer becomes a reference, somehow.
  • Tr/TrackProjectors/CMakeLists.txt
  • Tr/TrackTools/CMakeLists.txt
  • Tr/TrackTools/src/CountVeloTracks.cpp : velo -> VP
  • Tr/TrackTools/src/MeasurementProvider.h : remove ST
  • Tr/TrackTools/src/TrackSelector.cpp : remove obsolete detectors
  • Tr/TrackUtils/CMakeLists.txt

Formatting

  • Muon/MuonID/python/MuonID/ConfiguredMuonIDs.py
  • Muon/MuonID/python/MuonID/loadModule.py

Tests have not bee looked at yet. Some stuff may need to be restored.

Depends on LHCb!2804 (merged)

Edited by Patrick Koppenburg

Merge request reports