Skip to content

Removal of Velo, ST, OT, IT, PRS, SPD from master

Patrick Koppenburg requested to merge pkoppenb-removeObsoleteDets into master

Initial commit of LHCb cleanup for obsolete detectors and related event classes.

See overall picture at https://gitlab.cern.ch/lhcb-dpa/project/-/issues/18 https://gitlab.cern.ch/lhcb-dpa/project/-/issues/37

Complete removal of the following packages

  • Det/OTDet, Det/STDet, Det/VeloDet : these packages will be needed by Gauss and thus moved to Run2Support: Run2Support!6 (merged)
  • Event/VeloEvent, OT/OTDAQ, ST/STDAQ, ST/STKernel, ST/STTELL1Event, Velo/VeloDAQ
  • DAQ/Tell1Kernel

Changes:

  • Det/CaloDet/options/PrsDetTest.opts, Det/CaloDet/options/SpdDetTest.opts
  • Event/DigiEvent: Event/OTTime.h, ST*, Velo* are removed. dictionaries adapted. VeloCluster and VeloLiteCluster are kept temporarily to make LbCom happy (used in UT Lbcom#6).
  • Event/EventPacker: removal of packers dedicated to these subdetectors, adapt other code
  • DAQ/DAQSys : CMakeLists and tests adapted. read-split-raw.qmt cannot run with 2012 data. To be adapted.
  • Event/MCEvent/ : removal of Digit classes and fix of dictionary. Removal of MCVeloFE.h.
  • Event/RecEvent : fix dictionary. Unsolved issue with PV #102
  • GaudiConf/python/GaudiConf/PersistRecoConf.py fixed and tests fixed
  • Kernel/KernelSys/CMakeLists.txt cleaned
  • Kernel/LHCbKernel/ : classes deleted and LHCbID adapted. This may need a revision.
  • Tr/LHCbTrackInterfaces/TrackInterfaces/ISTClusterPosition.h removed
  • Event/LinkerInstances : dictionary adapted.
  • GaudiConf/python/GaudiConf/SimConf.py: Change default detectors to upgrade ones. This fixes most of the tests.
  • Ex/IOExample/tests/refs/*: some references slightly adapted.
  • Alignment-related files from Det/VeloDet moved to Det/VPDet.

Only formatting:

  • Kernel/LHCbMath : lb-format changes
  • Rich/RichUtils/src/RichTrackSegment.cpp : lb-format changes
  • Tools/GitEntityResolver : lb-format changes

Related cleanup MRs: Run2Support!6 (merged), Gauss!702 (merged), Lbcom!504 (merged), Rec!2236 (merged), Phys!810 (merged), Alignment!148 (merged), Analysis!747 (merged), DaVinci!498 (merged), Castelao!86 (merged), Panoramix!80 (merged),

Tangentially related move of LoKiGen: !2871 (merged) and Gauss!704 (merged)

Edited by Rosen Matev

Merge request reports