Skip to content

Draft: DO NOT MERGE Fixing the FT in DD4HEP

Louis Henry requested to merge lohenry-NOTTOMERGE-fixDD4HEP into master

Goes with Detector!267 (closed)

The hardcoded changes are:

  • Pr/PrKernel/include/PrKernel/PrFTZoneHandler.h : an unit conversion in sizeX and sizeY is not done properly
  • Pr/PrKernel/include/PrKernel/FTMatsCache.h:
    • Reverse the DDX and mirrorpoint X for layers 0 and 2
    • Add random (no clue why) small shifts here and there
    • Reverse the mat0, mat1, mat2, mat3 mirrorpoint Y in V alyers. This is due to the reversal as well
    • Reverse the 110 vs 120 y of the mirrorpoint in V layers. This is also due to the reversal as well
    • Hardcode some (not all..) globalDY. This is due to the fact that in Detector they shouldbe recalculated using the Box information, which is not done for now.

Most of these errors pertain to the fact that when we build layers 0 and 2, we take the same template as layers 1 and 3, but we reverse it. Visibly, there are lots of small directionalities that were not taken into account doing so, resulting in most of these issues.

Edited by Louis Henry

Merge request reports