WIP: fix MCLinking in TDR branch for LHCb::Tracks
@sponce , @raaij , @sstahl The solution I adopted to restore MCLinking for the LHCb::Tracks -> vector conversion, is to append in the MCSequence an algorithm reading all the tracks in the Track container and make a copy of them in /Copy/Track. This allow to run the PrChecker without any issue. Maybe this can be extended to other algorithm which do not allow to merge TDR to master. @gligorov , you may need this hack to setup a timing & efficiency test for CPU using the exact same software stack. To - do -list
-
Make the TrackConverter (move to functional) a 1-to-1 conversion One path In , One path Out (KeyedTrack) chained by the PrTrackAssociator using single containers. The final MCChecking sequence will be Per track type produced, i.e. MCCHeckingVelo, MCCheckingUpstream, MCCheckingForward, where optionally, whether no KeyedContainer is produced, a converter is placed in the sequence. -
Let TrackSys and UpgradeChecking sequence to know where converted Keyed tracks are located and which tracks have to be converted (this depends on the signature of the HLT algorithms, i.e. if they produce LHCb::Tracks or vectorLHCb::Track
Now, you can pass
TrackSys().TracksToConvert = ["Velo","Upstream","ForwardFast"]
to convert from vector<Track>
to LHCb::Tracks
when doing MC association.
Also
TrackSys().VeloUpgradeOnly = True
will execute VeloOnly ( and Decoding detectors) in the sequence.
The last can be useful concerning @cattanem suggestions in Brunel!344 (closed)
Merge request reports
Activity
added 1 commit
- 3d09b268 - apped in upgrade checking algorithm the track copy algorithm
I let @sponce to un-wip this merge request in case it's worth to test on the tdr nightly slot.
added 1 commit
- cd7bbee1 - fix UpgradeChecking TrackAssociator RootOfContainers
- Resolved by Renato Quagliani
added 42 commits
-
a9e95daf...116477d5 - 36 commits from branch
TDR
- 64e7cb15 - Add TrackConverter and let The Checker know about it
- 8ff48a04 - cleanup
- 4a1014ae - fix msgLevel
- d1533c50 - apped in upgrade checking algorithm the track copy algorithm
- 00495dfe - fix UpgradeChecking TrackAssociator RootOfContainers
- 16dfe614 - RootOfContainer: Copy -> Keyed
Toggle commit list-
a9e95daf...116477d5 - 36 commits from branch
added 1 commit
- 8ac871f7 - change path to KeyedContainers in TrackConverter
added 8 commits
-
8ac871f7...d3d26dc7 - 7 commits from branch
TDR
- 3129610b - Merge branch 'TDR' into 'TDR-rquaglia_fixhackMCLinking'
-
8ac871f7...d3d26dc7 - 7 commits from branch
added 63 commits
-
3129610b...d428e43a - 62 commits from branch
TDR
- a1a1c7c6 - Merge branch 'TDR' into 'TDR-rquaglia_fixhackMCLinking' use theirs everywhere
-
3129610b...d428e43a - 62 commits from branch
added 23 commits
- 6e22e311 - First steps towards using these Reco* functions to configure the HLT reconstruction.
- c764966b - Tweaks to the upgrade algorithm configuration.
- 4bd8586c - Add debug output.
- 640479e3 - Use LiteClusters.
- db9a1907 - Add missing return.
- dc54247a - Remove seqType argument from RecoVeloPr function.
- ca6f52f9 - Remove seqType from RecoUpstream function.
- 9bfa898e - Remove empty finalize().
- 2f95fd0c - Change python configuration to explicitly pass RecoUpgradeTracking the sequence…
- 2269bacc - Apply the GEC before storing hits.
- b3fda570 - Remove more implicit sequences.
- d413a42b - Remove more unused algorithms and revert the change to use LiteClusters in the…
- 3e6fe90f - Leave the decoders in the decoding sequence in the Brunel case.
- 3917ccdd - Don't force LiteClusters = True.
- 5fb8c137 - Remove small diffs w.r.t. the old naming.
- 5113365d - Add explanation about sorting.
- bc1fa33b - Add TrackConverter and let The Checker know about it
- 5919942c - cleanup
- 58e9cdc4 - fix msgLevel
- 3984db56 - apped in upgrade checking algorithm the track copy algorithm
- bf276d2e - fix UpgradeChecking TrackAssociator RootOfContainers
- 4e261816 - RootOfContainer: Copy -> Keyed
- 4cc15109 - change path to KeyedContainers in TrackConverter
Toggle commit listadded 1 commit
- 77323797 - reset to TDR version of RecoUpgradeTracking.py
added 1 commit
- ab0abe80 - revert TrackSys Configuration.py to default in TDR branch