WIP: fix MCLinking in TDR branch for LHCb::Tracks

@sponce , @raaij , @sstahl The solution I adopted to restore MCLinking for the LHCb::Tracks -> vector conversion, is to append in the MCSequence an algorithm reading all the tracks in the Track container and make a copy of them in /Copy/Track. This allow to run the PrChecker without any issue. Maybe this can be extended to other algorithm which do not allow to merge TDR to master. @gligorov , you may need this hack to setup a timing & efficiency test for CPU using the exact same software stack. To - do -list

• Make the TrackConverter (move to functional) a 1-to-1 conversion One path In , One path Out (KeyedTrack) chained by the PrTrackAssociator using single containers. The final MCChecking sequence will be Per track type produced, i.e. MCCHeckingVelo, MCCheckingUpstream, MCCheckingForward, where optionally, whether no KeyedContainer is produced, a converter is placed in the sequence.
• Let TrackSys and UpgradeChecking sequence to know where converted Keyed tracks are located and which tracks have to be converted (this depends on the signature of the HLT algorithms, i.e. if they produce LHCb::Tracks or vectorLHCb::Track

Now, you can pass TrackSys().TracksToConvert = ["Velo","Upstream","ForwardFast"] to convert from vector<Track> to LHCb::Tracks when doing MC association. Also TrackSys().VeloUpgradeOnly = True will execute VeloOnly ( and Decoding detectors) in the sequence. The last can be useful concerning @cattanem suggestions in Brunel!344 (closed)

Tf/TrackSys/python/TrackSys/PrUpgradeChecking.py

@@ -6,6 +6,7 @@ from GaudiKernel.SystemOfUnits import mm
 def PrUpgradeChecking(defTracks={}):
     # match hits and tracks
     log.warning("Run upgrade checkers.")
+
     from Configurables import (UnpackMCParticle, UnpackMCVertex,
                                PrLHCbID2MCParticle)
     # Check if VP is part of the list of detectors.
@@ -16,6 +17,8 @@ def PrUpgradeChecking(defTracks={}):
             if 'VP' in LHCbApp().upgradeDetectors():
                 withVP = True
     trackTypes = TrackSys().getProp("TrackTypes")
+    from Configurables import PrTrackConverter
+
     if "Truth" in trackTypes:
         truthSeq = GaudiSequencer("RecoTruthSeq")
         truthSeq.Members = [UnpackMCParticle(), UnpackMCVertex()]
@@ -44,8 +47,9 @@ def PrUpgradeChecking(defTracks={}):
     GaudiSequencer("CheckPatSeq").Members += [checker2]
     PrChecker2("PrChecker2Fast").addTool(MCHybridFactory)
     PrChecker2("PrChecker2Fast").Upgrade = True
-    PrChecker2("PrChecker2Fast").ForwardTracks = defTracks[
-        "ForwardFast"]["Location"]
+    PrChecker2("PrChecker2Fast").VeloTracks = defTracks["Velo"]["Location"]
+    #PrChecker2("PrChecker2Fast").NewTracks  = defTracks["VeloFitted"]["Location"]
+    #PrChecker2("PrChecker2Fast").ForwardTracks = defTracks["ForwardFast"]["Location"]
     PrChecker2("PrChecker2Fast").Eta25Cut = True
     PrChecker2("PrChecker2Fast").GhostProbCut = 0.9
     # PrChecker2("PrChecker2Fast").WriteTexOutput = True
@@ -68,4 +72,8 @@ def PrUpgradeChecking(defTracks={}):
     from Configurables import TrackResChecker
     GaudiSequencer("CheckPatSeq").Members  += [ TrackResChecker("TrackResCheckerFast")];
     TrackResChecker("TrackResCheckerFast").HistoPrint = False
-    TrackResChecker("TrackResCheckerFast").TracksInContainer = defTracks["ForwardFastFitted"]["Location"]
\ No newline at end of file
+    TrackResChecker("TrackResCheckerFast").TracksInContainer = defTracks["ForwardFastFitted"]["Location"]
+    
+    log.warning("Pre-appending a track copy in TES from vector<Track> to KeyedContainer to allow truth matching, this is an hack, not a final solution")
+    from Configurables import PrTrackConverter
+    GaudiSequencer("MCLinksTrSeq").Members.insert(0,  PrTrackConverter() )