Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • Urania Urania
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • UraniaUrania
  • Merge requests
  • !298

Merge DeltaMs related work

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Kevin Heinicke requested to merge dev-deltams-urania10 into adudziak_new_mdfit_urania10 Oct 29, 2020
  • Overview 45
  • Commits 107
  • Pipelines 0
  • Changes 94

Both, source and target branches are rebased on cleanup_Urania10. This contains a large amount of testing/debugging configs which could probably be (re)moved. Main review focus should be on everything inside /PhysFit/B2DXFitters/src, /PhysFit/B2DXFitters/scripts, and /PhysFit/B2DXFitters/python.

Let's discuss, @adudziak @jobutter 🙂

I also think noone will really gain anything from keeping 128 commits around. So I would say we can squash this MR. Even more so if we decide to apply lb-format.

This MR will fix #34 and #35 (closed). While some points of #34 will remain open it probably makes more sense to address them in a dedicated, more general code review.

Edited Nov 05, 2020 by Kevin Heinicke
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: dev-deltams-urania10