Skip to content
Snippets Groups Projects
Commit 7b4cb17a authored by Chrysoula Dikonimaki's avatar Chrysoula Dikonimaki
Browse files

update comment

parent cd65891b
No related branches found
No related tags found
1 merge request!21Update reconcile loop to check Secret instead of provisionStatus on ApplicationRegistration
Pipeline #10297517 passed
...@@ -36,8 +36,9 @@ func (r *GitlabPagesSiteReconciler) getOidcSecret(ctx context.Context, gitlabPag ...@@ -36,8 +36,9 @@ func (r *GitlabPagesSiteReconciler) getOidcSecret(ctx context.Context, gitlabPag
} }
} }
// Ensure we have a valid ApplicationRegistration registration, this only happens when we have exactly one ApplicationRegistration // Ensure we have a valid ApplicationRegistration. This can happen when the ApplicationRegistration is `Created` (the website should be up and running)
// with a status set by the authz-operator and this status says provisioning succeeded // or when the ApplicationRegistration has state `DeletedFromAPI` (the website should be blocked). To check if the ApplicationRegistration is in one of those two states,
// we can check if the oidc secret exists.
if appReg.Status.ClientCredentialsSecret == "" { if appReg.Status.ClientCredentialsSecret == "" {
meta.SetStatusCondition(&gitlabPagesSite.Status.Conditions, metav1.Condition{ meta.SetStatusCondition(&gitlabPagesSite.Status.Conditions, metav1.Condition{
Type: webservicescernchv1alpha1.ConditionTypeGitlabPagesSiteCreated, Type: webservicescernchv1alpha1.ConditionTypeGitlabPagesSiteCreated,
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment