Merge branch 'clang.TrigHLTJetHypo-20201208' into 'master'

TrigHLTJetHypo: Fix clang warnings.

See merge request atlas/athena!38991

Trigger/TrigHypothesis/TrigHLTJetHypo/TrigHLTJetHypo/TrigHLTJetHypoUtils/AllJetsGrouper.h

@@ -16,7 +16,7 @@ class AllJetsGrouper: public IJetGrouper{
   std::vector<HypoJetGroupVector> group(HypoJetIter&,
 					HypoJetIter&) const override;
   
-  std::optional<HypoJetGroupVector> next();
+  virtual std::optional<HypoJetGroupVector> next() override;
   
   std::string getName() const override; 
   std::string toString() const override;

Trigger/TrigHypothesis/TrigHLTJetHypo/src/TrigJetConditionConfig_capacitychecked.cxx

@@ -43,7 +43,7 @@ TrigJetConditionConfig_capacitychecked::getCapacityCheckedCondition() const {
 
 StatusCode TrigJetConditionConfig_capacitychecked::checkVals() const {
 
-  if (m_multiplicity < 1) {
+  if (m_multiplicity < 1u) {
     ATH_MSG_ERROR("m_multiplicity = " + std::to_string(m_multiplicity) +
 		  "expected > 0");
     return StatusCode::FAILURE;

Trigger/TrigHypothesis/TrigHLTJetHypo/src/TrigJetHypoToolConfig_fastreduction.cxx

@@ -116,7 +116,7 @@ TrigJetHypoToolConfig_fastreduction::getCapacityCheckedConditions() const {
   // return an invalid optional if any src signals a problem
 
   for(const auto& cm : m_conditionMakers){
-    conditions.push_back(std::move(cm->getCapacityCheckedCondition()));
+    conditions.push_back(cm->getCapacityCheckedCondition());
   }
       
   return std::make_optional<ConditionPtrs>(std::move(conditions));
@@ -128,7 +128,7 @@ TrigJetHypoToolConfig_fastreduction::getConditions() const {
   
   ConditionsMT conditions;
   for(const auto& cm : m_conditionMakers){
-    conditions.push_back(std::move(cm->getCapacityCheckedCondition()));
+    conditions.push_back(cm->getCapacityCheckedCondition());
   }
   
   return std::make_optional<ConditionsMT>(std::move(conditions));