Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
athena
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Locked files
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Peter Sherwood
athena
Commits
65a0bbb0
Commit
65a0bbb0
authored
6 years ago
by
scott snyder
Browse files
Options
Downloads
Patches
Plain Diff
VP1Utils: Fix gcc8 warnings.
gcc8 warnings: Catching polymorphic exception by value. Former-commit-id:
49d51d9b
parent
24aa6ab8
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
graphics/VP1/VP1Utils/VP1Utils/VP1SGAccessHelper.icc
+1
-1
1 addition, 1 deletion
graphics/VP1/VP1Utils/VP1Utils/VP1SGAccessHelper.icc
graphics/VP1/VP1Utils/src/VP1SGContentsHelper.cxx
+2
-2
2 additions, 2 deletions
graphics/VP1/VP1Utils/src/VP1SGContentsHelper.cxx
with
3 additions
and
3 deletions
graphics/VP1/VP1Utils/VP1Utils/VP1SGAccessHelper.icc
+
1
−
1
View file @
65a0bbb0
...
...
@@ -30,7 +30,7 @@ inline const T* VP1SGAccessHelper::retrieve( const QString& key ) const
try
{
t
=
storeGate
()
->
retrieve
<
const
T
>
(
key
.
toStdString
());
exception
=
false
;
}
catch
(
std
::
runtime_error
e
)
{
}
catch
(
const
std
::
runtime_error
&
e
)
{
exception
=
true
;
t
=
0
;
}
...
...
This diff is collapsed.
Click to expand it.
graphics/VP1/VP1Utils/src/VP1SGContentsHelper.cxx
+
2
−
2
View file @
65a0bbb0
...
...
@@ -56,7 +56,7 @@ bool VP1SGContentsHelper::contains( const CLID& id, const QString& key ) const
try
{
contains
=
m_sg
->
contains
(
id
,
key
.
toStdString
());
exception
=
false
;
}
catch
(
std
::
runtime_error
e
)
{
}
catch
(
const
std
::
runtime_error
&
e
)
{
exception
=
true
;
}
if
(
exception
)
{
...
...
@@ -84,7 +84,7 @@ QStringList VP1SGContentsHelper::getKeys(const CLID& id) const
try
{
keys
=
m_sg
->
keys
(
id
);
exception
=
false
;
}
catch
(
std
::
runtime_error
e
)
{
}
catch
(
const
std
::
runtime_error
&
e
)
{
exception
=
true
;
}
if
(
exception
)
{
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment