Merge branch 'gcc8.VP1Utils-20181001' into 'master'

VP1Utils: Fix gcc8 warnings.

See merge request atlas/athena!14626

Former-commit-id: c662d07d

graphics/VP1/VP1Utils/VP1Utils/VP1SGAccessHelper.icc

@@ -30,7 +30,7 @@ inline const T* VP1SGAccessHelper::retrieve( const QString& key ) const
   try {
     t = storeGate()->retrieve<const T>(key.toStdString());
     exception = false;
-  } catch (std::runtime_error e) {
+  } catch (const std::runtime_error& e) {
     exception = true;
     t = 0;
   }

graphics/VP1/VP1Utils/src/VP1SGContentsHelper.cxx

@@ -56,7 +56,7 @@ bool VP1SGContentsHelper::contains( const CLID& id, const QString& key ) const
   try {
     contains = m_sg->contains(id,key.toStdString());
     exception = false;
-  } catch (std::runtime_error e) {
+  } catch (const std::runtime_error& e) {
     exception = true;
   }
   if (exception) {
@@ -84,7 +84,7 @@ QStringList VP1SGContentsHelper::getKeys(const CLID& id) const
   try {
     keys = m_sg->keys(id);
     exception = false;
-  } catch (std::runtime_error e) {
+  } catch (const std::runtime_error& e) {
     exception = true;
   }
   if (exception) {