ToolSvc silently discards attempts to add duplicates.
But if configurableRun3Behavior is enabled, then those duplicates
may be distinct Configurable instances.  If we're also reading an old
configuration fragment, this can lead to errors about public tools
not being in ToolSvc.   Work around by forcing the owner of rejected
duplicates to be ToolSvc.  (Only enabled when configurableRun3Behavior is on.)

Scott Snyder authored 5 years ago and Edward Moyse committed 5 years ago

Initial python3 port.  Not intended to fix everything now; only what's
needed for basic athena/configuration jobs.

Add a flake8 unit test and make the python code compliant.


Former-commit-id: 51bdb0ef

Fix a (probably) harmless bug in some of the backwards-compatibility
code in AppMgr. There was a double negation (`not not`) and a comparison
to the wrong configurable type (Service instead of AlgTool).

In addition made the code handle lists of tools correct and added a unit
test for ToolSvc.__iadd__


Former-commit-id: 3a61baee

Event filtering was broken because the contents of athFilterSeq were
being unrolled into athMasterSeq, which in turn had StopOverride set
in order to ensure that registration always gets run.

Remove the unrolling, and move athRegStreams to athMasterSeq.


Former-commit-id: ac0fe07f

Walter Lampl authored 7 years ago and Vakhtang Tsulaia committed 7 years ago

Former-commit-id: c65ab80c

This MR has some fundamental changes in how the condition
handling mechanism works.

  - CondInputLoader must declare all the base classes of the
objects  it will produce. This requires the use of SG::BaseInfoBase,
and the CondInputLoader must initialize after the libraries where
those bases are defined are loaded.

 - Condition objects must register themselves with a static
factory so that the CondInputLoader can create CondCont of the
correct type. This is done via the REGISTER_CC( classname ) macro
found in AthenaKernel/CondCont.h

 - ReadCondHandleKey will not create a CondCont if it isn't
present. If one is, they will cache a ptr to it. This means that
ReadCondHandle may have to do a store lookup for their CondCont
if the cached ptr is null.

There are some other minor changes:

 - AthenaHiveEventLoopMgr can show the timestamp in the event
   heartbeat if property ShowTimeStamp is set
 - a number of interfaces for the AlgExecStateSvc have changed
   in gaudi v29, and these are reflected in athena code


Former-commit-id: f6871bf3

scott snyder authored 7 years ago and Sanya Solodkov committed 7 years ago

Turn on StopOverride for AthMasterSeq to ensure that the registration
sequence will always get run.


Former-commit-id: eed25254

This reverts merge request !1

Former-commit-id: 99708750

This reverts commit 391deef5 [formerly 89865472dae2fbf96d02f0053cd2836ae6a765c2]

Former-commit-id: 1bf34570541f0f4d85483d85077001059e75e0d1

Turn on StopOverride for AthMasterSeq to ensure that the registration
sequence will always get run.


Former-commit-id: 7c5576ab

If an algorithm filter fails, then AthAlgEvtSeq could return early,
skipping the end-of-event incident processing algorithms.
Turn on StopOverride for this sequence so that the end-of-event
algorithms will always get run.



Former-commit-id: 49f6d4f6

Don't import athBegin and athEnd sequences with All. Change indent on TopAlg and AthCondSeq when dumping


Former-commit-id: 7615e1d0

Adding incident forwarding for Storegate and start() method to CoreDumpSvc to set number for slots from concurrencyflags.


Former-commit-id: a506fa9c

Former-commit-id: b49930f9

Former-commit-id: b136c08a

Created AthCondSeq for CondInputLoader and Conditions Algs. Added PixelCalibCondAlg
to AthCondSeq.


Former-commit-id: 868f4ef6

Former-commit-id: 9e350c81

Former-commit-id: ff4fab5f

Added AthBeginSeq and AthEndSeq sandwitching around AthAlgSeq to
handle Incident Processing Algorithms

2017-01-25 Steve Farrell <Steven.Farrell@cern.ch>
        * Setting _threaded attribute of PyROOT-bound C++ methods in
          AthAppMgr in order to release the python GIL. The flag is set
          according to ConcurrencyFlags.NumThreads() and is set for the
          initialization, executeRun, and finalization calls.
        * Tagging: AthenaCommon-03-03-21


Former-commit-id: efaefbcf

'Add workaround needed in gaudi 28 for problem with pyroot passing arguments to rvalue references.' (AthenaCommon-03-03-19)

	* Tagging AthenaCommon-03-03-19.
	* python/ConfigurationShelve.py (loadJobOptionsCatalogue): Add
	workaround needed in gaudi 28 for problem with pyroot passing
	arguments to rvalue references.

2016-12-20  Vakho Tsulaia  <tsulaia@cern.ch>
	* Fixing release_metadata() function such that it can work with non-consistent ReleaseData files (local MIG problem)
	* Tagging AthenaCommon-03-03-18

2016-11-30  scott snyder  <snyder@bnl.gov>

        * Tagging AthenaCommon-03-03-17.
	* python/JobProperties.py (JobPropertyContainer.__getattribute__):
	Fix infinite recursion introduced by last change.

2016-11-28 Walter Lampl <walter.lampl@ cern.ch>
	* print suggestions for mis-spelled property names
	* tag AthenaCommon-03-03-16


Former-commit-id: d11920e5

        * Tagging AthenaCommon-03-03-15.
	* python/AppMgr.py (AthAppMgr.initialize): Workaround for
	ATLASRECTS-3486: touch some STL types early to avoid spurious
	errors from ROOT.  Did not add vector<char>/vector<unsigned char>
	at this point as they are in the xAODCore rootmap.

2016-09-04  scott snyder  <snyder@bnl.gov>

        * Tagging AthenaCommon-03-03-14.
	* Revert -13.

2016-06-09 Will Buttinger <will@cern.ch>
        * python/Configurable.py: stop handle properties from adding their properties to joboptionssvc unless they are non default
        * tag AthenaCommon-03-03-13


Former-commit-id: ebee448b

	* Adding 'base release' to the dictionary returned by release_metadata (required by the Obsolete Geometry mechanism)

2016-03-15  Frank Winklmeier  <fwinkl@cern>
	* python/PropertyProxy.py: Remove unnecessary string formatting in _isCompatible (twice faster)
	* tag AthenaCommon-03-03-11

2016-02-16  Charles Leggett
	* create ConditionStore for threaded jobs
	* tag AthenaCommon-03-03-10

M       python/AtlasThreadedJob.py

2016-02-09  Vakho Tsulaia  <tsulaia@cern.ch>

	* Introducing new command-line option for athena.py: --profile-python (OBO Wim)
	* tag AthenaCommon-03-03-09

	* Tagging AthenaCommon-03-03-05.
	* From John Baines:
	* Add FTK to DetFlags.

2015-09-21  scott snyder  <snyder@bnl.gov>

	* Tagging AthenaCommon-03-03-04.
	* python/AppMgr.py (AthAppMgr.setup): Fix set of setupok.  Update
	message for adding an algorithm with properties not set from debug
	to error.