Frank Berghaus authored 4 years ago and Vakhtang Tsulaia committed 4 years ago

Enforce concistent style for source files defining the three
FileMetaData conversion tools.

Vetoing variables from a ShallowAuxContainer had a couple problems.

 - When testing for whether we can do a simple copy, we also need to check
   that there are no variable vetoes.
 - Fix setting of number of elements to be copied in the case of 
   variable vetoes but no thinning.
 - When we copy variables, the new container should always be set 
   for shallowIO.  All the variables we want to write will be copied
   to the new container.  Any that are in the parent but not the new
   container will have been explicitly vetoed.

Don't crash in ByteStreamEventStorageOutputSvc if there's no 
bytestream metadata.  (Can happen for example if we're reading pool
and writing bytestream.)

In RDP_ByteStream_jobOptions, add EventInfo as an additional dependency
of StreamBS.  (Needed for SCT_RawDataByteStreamCnv tests.)

Using ATH_CHECK to handle the return of querying the interface of the
base class means a return here only happens on failure. This is exactly
the opposite of what we wanted. Introduced by mistake.

Remove unneeded thread annotation.

Frank Berghaus authored 4 years ago and Vakhtang Tsulaia committed 4 years ago

The extends template takes care of the onerous tasks of implementing the
functionality required for interactions with the service interface. This
just streamlines the code a bit and ensures the interface accessors are
correctly implemented.

Bertrand Martin Dit Latour authored 4 years ago and Vakhtang Tsulaia committed 4 years ago

Hello,

This MR is harmonising the use of tau track IP and IP significance parameters across the tau reconstruction.
We now use everywhere the impact parameters w.r.t. the tau vertex instead of w.r.t. beam line (relevant for d0).
New methods are introduced to retrieve the track IP and IP significances directly from the tau track (before, we would use e.g. d0 from the associated TrackParticle, i.e. d0 w.r.t. the beam line).

Because we need track IPs early in the reconstruction (right after tau vertex finding and tau track association, and before tau track classification), I had to move the track IP calculation from TauVertexVariables to TauTrackFinder, as TauVertexVariables is scheduled late in the reconstruction chain.

Two variables have been discontinued: TauJetsAux.ipSigLeadTrk TauJetsAux.ipZ0SinThetaSigLeadTrk. These are track IPs defined for the leading track. Now that we compute these for all tau tracks, we can drop these "leading track" variables.

Using standalone tau reconstruction from ESD, I have checked that the tau reconstruction output is unchanged if I fall back to the "old" calculations for track IPs, i.e. if I set d0TJVA = track()->d0(), and z0sinthetaTJVA = z0sinThetaTJVA(tau) in Track_v1.
Meaning, this MR is mostly code reorganisation. The only modification that changes the reconstruction is the new definition of d0TJVA and z0sinthetaTJVA.
With these new definitions, we get slight changes on the BDT ID score and the RNN ID score, as well as the track classification scores, as expected.

Cheers,
Bertrand

That has been superseded by AsgMessaging/MessageCheck.h.

Frank Berghaus authored 4 years ago and Adam Edward Barton committed 4 years ago

This has just laid dormant ever since the CMT->CMake migration. :-(

At the same time introduced some tests for the implicit copy-constructor
and copy-operator of xAOD::EventFormat.

1. Use EventInfo instead of EventStreamInfo for retrieving mcChannelNumber

2. Access TagInfo information from the input metadata store in the first handler
of BeginRun incident. Cache this information and use it for setting values
of relevant fields of Truth metadata

Also dropped atlas_depends_on_subdirs() from CMakeLists.txt

The single RegSelSvc is to be replaced by a separate RegSelTool for each subsystem.

This merge request is to implement that migration for the ID code.

This code contains about 60 % of all the changes that are needed for the migration,
and most of the changes for the pixel, SCT and TRT.

```
For information the packages needing changes are
Innerdetector/InDetEventCnv/PixelRawDataByteStreamCnv
InnerDetector/InDetEventCnv/TRT_RawDataByteStreamCnv
InnerDetector/InDetExample/InDetRecExample
InnerDetector/InDetRecAlgs/InDetPrepRawDataFormation
InnerDetector/InDetRecTools/TRT_SeededSpacePointFinderTool

Reconstruction/TRT_Rec
Reconstruction/iPat/iPatRecExample

Innerdetector/InDetExample/InDetTrigRecExample

InnerDetector/InDetTrigRecAlgs/InDetTrigPrepRawDataFormat
InnerDetector/InDetTrigRecAlgs/InDetTrigRawDataProvider
InnerDetector/InDetTrigRecAlgs/SiTrigSPSeededTrackFinder
InnerDetector/InDetTrigRecAlgs/SiTrigSpacePointFormation
InnerDetector/InDetTrigRecAlgs/TRT_TrigSeededTrackFinder
InnerDetector/InDetTrigRecAlgs/TRT_TrigTrackSegmentsFinder

Trigger/TrigTools/TrigOnlineSpacePointTool
Trigger/TriggerCommon/TriggerJobOpts

Trigger/TrigAlgorithms/TrigGenericAlgs
Trigger/TrigAlgorithms/TrigT2MinBias
Trigger/TrigHypothesis/TrigLongLivedParticlesHypo
```

plus the configuratin for every package that uses any of the above packages which will need to
instantiate the RegSelTools for the tool and algorithms configurables.

Fix muon null pointer comparison.  (Was using the wrong Muon).

Fixes test failure in JetEventAthenaPool.

Enable thread-safety checking.

Rachid Mazini authored 4 years ago and Atlas Nightlybuild committed 4 years ago

Add overrides for HEC in overlay HI production

See merge request atlas/athena!36563

(cherry picked from commit 67ab0ca7f9030bb84336352ae8893d38a96759d2)

b40cc37b Override BadChannels folders for HI production (ATLHI-200)

Don't fail if JetAssociationBase or Muon are not available.
cf ATLASSIM-4772

merge in patch to EDM, and remove duplicate use of the DATAVECTOR_BASE macro (temporarily commented out, will remove in due course)