Prevent declaring dependencies on conditions objects we won't read.
(Old config.  I think new config is ok.)

TileRawChannelGetter has been updated to retrieve easy the following
private Tile raw channel builder tools:
- TileRawChannelBuilderFitFilterCool;
- TileRawChannelBuilderMF;
- TileRawChannelBuilderOF1;
- TileRawChannelBuilderWienerFilter.
and to set up correctly DSP container in TileRawChannelBuilderOF1 tool.

JO (jobOptions_TileCalibRec.py) used in reconstruction of Tile calibration runs
has been updated:
- to use correctly private tools mentioned above;
- to add 2020 year (used to find data);
- to ignore DMU errors in Tile Demonstrator;
- to use new conditions tags.

Additional Tile timing type configuration flag has been added for run 3.
Tile timing configuration has been modidfied to use this flag.
Tile raw channel time monitoring algorithm configuration for run 3
has been modified to use this flag
Tile DQ status configuration for run 3 has been modified to use this flag
to avoid set up Tile beam container in the case of laser in gap.

There are no usefull information in pool input file for Tile DQ status.
So, no input containers for Tile DQ status algorithm have been set up
in the case of pool input file.

Updated `ComponentAccumulator` configuration tests which dump the configuration to a pickle file.
In python 3 the output file needs to be explicitly opened in binary mode.
I.e.
```
f = open('configdump.pkl', 'wb')
```
rather than
```
f = open('configdump.pkl', 'w')
```

Vojtech Pleskot authored 5 years ago and Vakhtang Tsulaia committed 5 years ago

The code is moved from an update that wasn't finished before ATLAS
opened its software in December 2018. The move to the public repository
was done via a patch file generated from the old repository.
The command git apply --reject patchfile.patch was used
together with a carefull inspection of the rejected hunks.

Adds Wiener Filter weights for luminosity <mu>=90.

Configurations of Tile reconstructions components for run 3
have been udpated to allow pass additional parameters
and make them more configurable.

Siarhei Harkusha authored 5 years ago and Frank Winklmeier committed 5 years ago

The Tile reconstruction method TileOpt which uses OFCs from files
will be removed soon since there is identical method TileOpt2
wich uses OFCs from DB or calculated on the fly
and in order to avoid support/synchronyze both of them.

At this step Tile flag doTileOpt which schedules
TileOpt reconstruction method has been removed.

This consists of two fixes. The first ensures that `TileDigitsMaker`
declares the proper dependencies by adding `SG::ReadHandles` for the
background `TileDigitsContainer` and `TileRawChannelContainer` (although
this is not part of the background RDO file). In order to preserve old-style
approach using the `PileUpMergeSvc` then it is necessary to make a copy of
the `TileDigitsContainer`, but this can probably be dropped with  more substantial
refactoring.

The second fix involves changes to ensure that the `TileDQstatusTool` is only called
once during the event loop and to avoid there being two attempts to record the `TileDQstatus`
object in the ConditionsStore. Therefore `TileDQstatusAlg` is not added to the `AlgSequence`
in Overlay jobs.
Possibly it would be cleaner to remove the usage of the `TileDQstatusTool`
from `TileDigitsMaker` and just read the `TileDQstatus` object from the ConditionsStore.
`TileDQstatusAlg` could then be run, but be configured to read the background `TileDigitsContainer`.

Tile raw channel maker configuration to produce raw channels
from HS truth digits in new style for run 3 has been added.

Tile digitization cofiguration for run 3 has been updated
to produce Tile raw channels from HS truth digits
and put them into output file.

Calo cell container checker tool has been configured correctly
in new style Tile cell maker configuration for run 3.

introduce new style CaloCellCorrectionConfig with CaloCellPedestalCorr and CaloCellNeighborsAverageCorrCfg (the latter moved here from TileCellMakerConfig)

Unifying new-style LAr config for Digi & Reco. Delete some obsolete stuff copied over from the old config (squashed version)

Added possibility to put Tile raw channel containers
produced by Tile raw channel maker into output file.

Configurations of Tile raw channel builders have been updated
to allow pass additional options, make some required arguments explicit,
and remove some unnecessary arguments in configuration functions.

Configuration of Tile raw channel builder using MF method has been added for Run 3.

Test for Tile MF raw channel builder configuration has been added.

In the case when Tile raw channel builder tool with Fit method
is used for fitting overflowed Tile raw channels
avoid unnecessary initialization of input Tile DQ status,
output Tile raw channel container,  and noise filter tools.

Configuration of Tile cell maker has been added for Run3.

Configuration of Tile raw channel builder using Optimal Filtering
methods has been updated to set up correctly pedestal mode.

Tests for Tile cell maker has been added.

Configuration of Tile cell builder tool has been added for Run3.
Configuration of Tile cell noise filter tool has been added for Run3.
Tests for Tile cell builder and noise filter have been added.

Tile raw channel maker configuration for Run3
has been refactored to avoid code duplication.

Test for Tile DQ status algorithm has been added.

Adds the Wiener Filter method for energy reconstruction in the Tile Calorimeter

Configuration of Tile raw channel builder using Fit  method has been added for Run3.

Configurations of Tile raw channel builders using Optimal Filtering methods
(OF1, Opt2, OptATLAS) have been added for Run3.

Configuration of Tile raw channel maker has been added for Run3.

Tests for Tile raw channel builders (Fit, OF1, Opt2, OptATLAS) and
raw channel maker have been added.

Configuration of Tile DQ status tool and algorithm have been added for Run3.

Configurations of Tile raw channel correction tools and
corresponding algorithm have been added for Run3.

Test for Tile raw channel correction algorithm has been added.

Flake test has been added for files in python and test directories
and some issues found by test have been fixed.

In the case when not all Tile digits are available offline
and therefore not all Tile raw channels are built
noise filters should be applied to full Tile raw channel
container which comes from DSP and then the same corrections
should be applied to incomplete Tile raw channel container
built offline in Tile raw channel builder tool.

And then corrected Tile raw channel container built offline
is merged with corrected container which comes from DSP
during Tile cells creation in Tile cell builder tool.

Since in AthenaMT modification of Tile raw channel container
which comes from DSP is not possible local mutable copy of it
is created and used in Tile raw channel builder tool.

Unfortunately in this case Tile cell builder doesn't see
the corrected Tile raw channel container from DSP
and therefore original (uncorrected) container is merged
with corrected Tile raw channel container built offline.

Now new TileRawChannelNoiseFilterAlg is introduced which
applies noise filters to input Tile raw container (from DSP)
and puts corrected container into store gate to be used by
Tile raw channel builder tool and Tile cell builder tool.

Tile noise filter has been switched on for data overaly.

During processing data Tile raw channel container from DSP
is needed to find corrections and apply the same ones
to the Tile raw channel container built offline.

But in the case of MC or overlay jobs
DSP corrections should not be applied
and therefore Tile raw channel container from DSP
is not needed in Tile raw channell builders also.