Mark calls to CollectionFactory / CollectionService as not thread-safe.

ICollectionMetadata::const_iterator now takes a unique_ptr.

ICollectionMetadata::const_iterator now takes a unique_ptr.

ICollectionMetadata::const_iterator now takes a unique_ptr.

Enable thread-safety checking.
Fix resulting warnings.
CollectionFactory / CollectionService marked as not thread-safe
due to const-correctness violations.

    
Remove reference to obsolete header StoreGate.h.

    
Remove reference to obsolete header StoreGate.h.

    
Remove reference to obsolete header StoreGate.h.

Small update for the new pyroot in root 6.22: std::string is no longer
automatically converted to a python string.

Frank Berghaus authored 4 years ago and Vakhtang Tsulaia committed 4 years ago

The updates to EventFormatStreamHelperTool mean that there are
additional and updates information from the StreamHelperTool and
EventFormat content in the output streams. The references should relect
those changes.

Fix: IOVDbSvc was holding on PoolSvc contextID over fork and
I/O reinit, after which it was invalid and interfering with other
contexts. Made IOVDbSvc a client of IIoComponentMgr to reset the context

PoolSvc was not cleaning up its map of contexts fully at I/O reninit
- fixed

MetaDataSvc transitionMetaDataFile was refusing to run for ES
- cleared the blocking unnecessary flag

Implemented handling of "end of range" NextEventRange incidents for
MP mode

Remove unused and undefined ROOT_INCLUDE_DIRS.

Remove unused and undefined COOL_LIBRARIES.

Put positional parameters first.

Frank Berghaus authored 4 years ago and Adam Edward Barton committed 4 years ago

This has just laid dormant ever since the CMT->CMake migration. :-(

At the same time introduced some tests for the implicit copy-constructor
and copy-operator of xAOD::EventFormat.

Previously the module would only work correctly if somebody upstream
already imported the AthenaCommon.AthenaCommonFlags module. With this
update it is now possible to import this module from vanilla Python
as well.

Fix test failures in master.

Peter Onyisi authored 4 years ago and Edward Moyse committed 4 years ago

Need <cstdlib> for size_t.

Frank Winklmeier authored 4 years ago and Walter Lampl committed 4 years ago

Add missing TestTools dependency for test executables.

Fix for bug introduced in !36278. Reading the `OverrideRunNumber`
property directly from the `EventSelector` does not work in case the
`EventSelector` has not been initialized yet (ATLASSIM-4767). Change the
code again to use the `JobOptionsSvc` to read the properties.

Pass class instances by const reference, not by value.

Enable thread-safety checker and fix identified issues.

`IJobOptionsSvc` is deprecated. Instead use the `IProperty` interface
directly to read the properties of the `EventSelector`.

Clang warns about an unused argument in the boost parameter code.
Suppress it.

Enable thread-safety checker.
Fix identified issues.