ThinningSvc is no longer used and is being removed.

Frank Berghaus authored 4 years ago and Walter Lampl committed 4 years ago

The ByteStreamEventStorageInput service provided a legacy job option called FullFileName to specify bytestream input. With the move to EventSelector this option was all but removed from ByteStreamEventInputSvc. The EventSelectorByteStream provieded the input option to specify input. It captured the FullFileName option of the InputSvc. This commit removes the relevant parts of the ByteStreamEventStorageInputSvc and EventSelectorByteStream. It also attempts to move all references in other job options (unless they specify being for an older release).

Run LumiBlockMuWriter on BS files or if the input file already
has xAOD::EventInfo.  Needed to fix some trigger ART tests.

It will fill the decorations with 0 in this case.

fix the setting of beam_energy and AMITag to avoid saving more than one value in the TagInfo metadata

Introduced new LumiBlockMuWriter algorithm, which fills pileup information
on xAOD::EventInfo using  WriteDecorHandle-s.

Enabled LumiBlockMuWriter algorithm in RecExCommon_topOptions.py for RAWtoESD
configurations over ByteStream input, and also unconditionally in
skeleton.RDOtoRDOtrigger.py and in runHLT_standalone.py

Ported one client - JetCalibrationTool - to accesing pileup
values in xAOD::EventInfo using ReadDecorHandle

Fixed ref_RDOtoRDOTrig_mt1_build.ref with updated trigger counts

StatusCodeSvc is deprecated. Remove all references to it from job
options.

 - print function
 - exec
 - except statement syntax
 - long
 - don't suppress error messages.

Scott Snyder authored 5 years ago and Walter Lampl committed 5 years ago

TauTrackSlimmer operates on the run 1 EDM and is in fact never enabled anywhere
in the current release.

Remove it, in order to allow eventually removing the old thinning service.

Schedule FTKFastSimTruth before trigger simulation

See merge request atlas/athena!26339

(cherry picked from commit 712841b1375d92a5f5bbe5e1a56ecdb3fbbafad3)

c409ab36 Add FTKFlags.doTruthSmearing flag
2501f873 Add tools/algs from TrigFTKFastSimTruth_jobOptions to FTKRec
18e8c696 Split FastSimTruth from FTKRec and only schedule this part before the trigger
c25466d9 Protect FTKFastSimTruth inclusion

Scott Snyder authored 5 years ago and Frank Winklmeier committed 5 years ago

Migrate xAODEventInfoCnvTool from using LuminosityTool to  LuminosityCondAlg.

Add a configuration fragment, xAODEventInfoCnvAlgDefault, which will set up
the luminosity conditions algorithm; it also disables running the algorithm
at BeginRun.

In passing, resolves ToolHandle constness issues.

Do not schedule ThinInDetForwardTrackParticles if we're reading
from ESD and InDetForwardTrackParticles is not in the input file.

Fixes failure seen in q223.

John Kenneth Anders authored 5 years ago and Atlas Nightlybuild committed 5 years ago

Fix trigger selector in RecExCommon/Reco_tf

See merge request atlas/athena!23909

(cherry picked from commit 65d1784e00899869e1abb10404b285a55d664b5b)

1a5d3f08 Fix trigger selector in RecExCommon/Reco_tf

Given the new EventInfo is an xAOD object, it requires two converters: one for the interface
object and one for the Aux store. The names of new converters are:
	EventInfoByteStreamxAODCnv
	EventInfoByteStreamAuxCnv

James Beacham authored 7 years ago and James Catmore committed 5 years ago

Thinning of InDetForwardTrackParticles container in the primary AOD

See merge request !5650

Former-commit-id: 364c089c4a7154e50298a322ce3d14f4688b4609

This reverts merge request !21559

EventInfoNonConstCnvAlg was introduced in 21.0 and was not meant to be migrated
to the master. The goal of this manual cherry-pick is to provide a quick
workaround to the problems discussed in ATEAM-506.

Also added some protection against the usage of EventInfoNonConstCnvAlg in
AthenaMT

Do not use `AthenaServices.SetFatalHandler` but instead set the
equivalent property on the CoreDumpSvc. Switch the remaining job options and
delete any comments referencing the old class.

A nice side effect is that the initial bootstrap of `athena.py` is now 3
seconds faster due to the removal of the `cppyy` import (of course this
time is spent later once the import happens at another place).


Former-commit-id: 021e1688

This reverts merge request !15357

Former-commit-id: eda457df

Former-commit-id: d33bbc09e0acba3df4475d2a6327dbde186dff41

Susumu Oda authored 6 years ago and Frank Winklmeier committed 6 years ago

Former-commit-id: 77fe9ea2

Former-commit-id: cbd0bad6

Now that CaloCellContainerFromCluster retrieves clusters using ReadHandles, crashes will occur if said clusters don't exist.
This can occur if, for instance, muon or egamma reco is turned off by ART jobs (both groups have observed this problem recently).
This fix ensures that the muon and egamma clusters are only added to the list of clusters to be made into containers if their respective reconstructions are actually performed.


Former-commit-id: 51cd4231