Hello,

This MR adds the functionality to thin the CaloCalTopoClusters_links container and only keep the entries associated with tau clusters.
This container is needed for the tau cluster-to-cell navigation in xAODs, but it too large to be written out without thinning.
As discussed in ATLTAU-1733, the CaloClusterCellLinkContainer thinning was not supported so far, and Scott just implemented it (not merged yet).
Once it's in Athena, the CaloCalTopoClusters_links size should be reduced significantly (I'm already adding the container to the xAOD output to minimise the number of MRs, so we expect a jump in xAOD size, ATLASRECTS-5684).
According to q221 run on 40 events, thinning reduces the container size by a factor of 2.5 (3.0 kb/evt after thinning).

Cheers,
Bertrand

  - omit manual symmetrization of matrix fed into SelfAdjointEigenSolver (not necessary according to eigen-doc)
  - omit second check for eigenvalue !=0

Hello,

This MR is implementing an improved version of the tau pi0 cell thinning in xAODs (ATLASRECTS-5684, ATLTAU-1733).
The pi0 clusters are initially built from cells stored in a separate container (TauCommonPi0Cells).
An algorithm (ClusterCellRelinkAlg) is introduced to recreate pi0 clusters with cells from the main cell container (AllCalo), thereby eliminating the overhead from our separate cell container.
The ESD and AOD contents have been adjusted accordingly: TauCommonPi0Cells is dropped, and the relinked pi0s are written out instead of the initial pi0s.
There will be a follow-up MR that will drop some other pi0 container we used to use in TauPi0ClusterCreator, which should no longer be needed.
For now, only the minimum amount of TauPi0ClusterCreator code was changed.

Another algorithm (TauCellThinningAlg) is introduced to save the cells from the tau seed-jet topoclusters in xAODs.
Only clusters within 0.2 of the tau are considered, to limit the xAOD size increase.
Note: in the xAODs, we are still missing CaloCalTopoClusters_links (the CaloClusterCellLinkContainer) for the tau seed-jet clusters.
An attempt at thinning this container was made, but it was not successful.

Cheers,
Bertrand

Fix test failure in master.

 - A generation of -13 was never actually written to the DBs.
   Set the default back to -12.
 - Fix cool tag names for offline case (start with CaloOfl).
 - If we request configuration with a global cool tag, preserve that
   for each folder rather than resolving to a folder-specific tag.

See ATR-22193.

Susumu Oda authored 4 years ago and Walter Lampl committed 4 years ago

Remove obsolete SiRegionSelectorTable, TRT_RegionSelectorTable, SCT_CablingToolInc, (I)SCT_FillCabling(FromTest/CoraCool)

Helps in propagating the key for the CaloNoise dependency.

Remove obsolete class ToolWithConstantsMixin.

Fix typo in comments.

Remove CaloRunClusterCorrection, and remove the remnants of it
from the configuration.

Allow reading configuration parameters from a pool file again.

Allow configuring using the global tag again.

Now the sequence of tools is always configured statically, though
their parameters may change during the run.

Switch cluster correction configuration to use new-style configuration,
and new (CompFactory) configurables.

Add a unit test for cluster correction configuration.

Fix flake8 warnings.
Other cleanups.

    
Remove reference to obsolete header StoreGate.h.

Clean up CaloTowerBuilderToolTestAlg, allowing it to be checked.

IToolWithConstants needs to derive  from IAlgTool.

Update CaloClusterCorrDBWriter to use ToolWithConstants,
rather than the obsolete ToolWithConstantsMixin.

Add new-style configuration flags for cluster corrections.
(To allow migrating cluster corrections to the new configuration scheme.)

    
Remove reference to obsolete header StoreGate.h.

    
Remove reference to obsolete header StoreGate.h.

    
Remove reference to obsolete header StoreGate.h.

    
Remove reference to obsolete header StoreGate.h.

Fix test failures in master.

Remove reference to obsolete header StoreGate.h.

Cleanup cmake configuration of Calorimeter packages:
- remove `atlas_depends_on_subdirs`
- update link dependencies
- remove unused externals
- remove installation of headers if they are not used outside the
  package