1. Cleanup boilerplate code
2. Change property declaration to new method
3. Change function names in AthMonitorCfgHelper
4. Add AOD to TestDefaults.py
5. Add override keyword to functions

- `HistogramDef`: fix a parsing bug where the histogram definition
  string had to end with a trailing comma for 1D histograms without
  labels and options.
- Remove the trailing comma produced by `defineHistogram`
- Adapt the existing C++ unit tests and add a test for `TProfile2D`
- Deprecate the use of "label1:label2" syntax in `defineHistogram`
- Add a unit test for the `defineHistogram` method
- Change line endings from DOS to UNIX in source files

The default value for the `HistPath` property was by mistake changed in
commit 4a2edffa and broke the automatic booking of histograms under the
tool's parent's name. Revert the default value back to an empty string
and improve documentation.

Also some general cleanup of the code:
- remove irrelevant `virtual`
- remove declaration of `InterfaceID`
- remove import of `std` namespace as `std::` was used in most places
- spell and grammar check

Peter Onyisi authored 6 years ago and Vakhtang Tsulaia committed 6 years ago

Former-commit-id: 282d6a051779f134cc8f18349e88e8d2d38a39ff

Thanks to atlas/Gaudi!149 and atlas/athena!4537, we can now define empty
ToolHandles in header files as well. Other changes:
- Update doxygen
- Allow 'list' in labels argument to defineHistogram
- Add 2D histogram example to AthExMonitored


Former-commit-id: 1ce9fb13cb0e616b1ebdf305aa30bb0dc5260601

Tamara Vazquez Schroeder authored 7 years ago and Atlas Nightlybuild committed 7 years ago

Revert "Merge branch '21.0-dq-event-filter' into '21.0'"

See merge request !4538

Former-commit-id: 32c926b0

Tamara Vazquez Schroeder authored 7 years ago and Atlas Nightlybuild committed 7 years ago

21.0 dq event filter

See merge request !3963

Former-commit-id: ac6c4b8a

Introduce a custom Configurable for the GenericMonitoringTool in case we
need to add extra (python) features later. Also move the defineHistogram
function into this module. Adapt all client code.


Former-commit-id: 2f61e7a2

Changes in GenericMonitoringTool:
- Change property name HistogramsGroupName->HistPath
- Add VoidMonitoringTool() class to help defining an empty monitoring
  tool
- Update documentation

Changes in MonitoredScalar/Collection:
- Replace MonitoredHelpers with c++11 traits
- Update documentation

Changes in MonitoredScope:
- Update documentation and indentation

Changes in MonitoredTimer:
- Require all timers to start with a common prefix ("TIME_"

Changes in L1Decoder:
- Link component library directly against installed library
- Update FakeRoI to use GenericMonitoringTool instead of trigger one

Deleted obsolete files:
- GenericMonitoringToolTest_jobOptions.py
- MonitoredHelpers.h


Former-commit-id: f710b317

Former-commit-id: 0fb4d890

Former-commit-id: d2ee000c

	* Add protection for case rec.doTrigger==False and DQMonFlags.useTrigger==True
          obo Ryan White.  This mode of operation is NOT SUPPORTED BY DQ.
	* Tag AthenaMonitoring-02-03-06

2016-09-22 Harish Potti<harish.potti@cern.ch>
	* Add doAFPMon flag
	* Tag AthenaMonitoring-02-03-05


Former-commit-id: ffc99a51

	* Reintegration of 02-02-00-branch (changelogs below)
	* Tag AthenaMonitoring-02-03-04

2016-09-08 Peter Onyisi <ponyisi AT cern.ch>
	* Enable HI monitoring for HIP runs
	* Tag AthenaMonitoring-02-02-00-08

2016-08-11 Peter Onyisi <ponyisi AT cern.ch>
	* Enable pixel monitoring in ZeroBias obo Yosuke Takubo
	* Tag AthenaMonitoring-02-02-00-07

2016-06-21 Peter Onyisi <ponyisi AT cern.ch>
	* Fix ATLASRECTS-3216
	* Other changes obo Benjamin Trocme
	* Tag AthenaMonitoring-02-02-00-06

2016-06-20 Peter Onyisi <ponyisi AT cern.ch>
	* Enable plot X axis extension when plot is vs LB (only TH1 derivatives)
	* Fix bug in histogram output areas when LB is skipped
	* Actually switch TDT to global instance
...
(Long ChangeLog diff - truncated)


Former-commit-id: eef3609d

2016-03-30  scott snyder  <snyder@bnl.gov>
	* Tagging AthenaMonitoring-02-03-01.
	* Coverity 12548, 13134, 106180, 12394, 30123, 30200-30207.
	* Tagging AthenaMonitoring-02-03-00.
	* Moving to replace access to protected members with calls to
	functions (and clean up naming convention violations in the
	process).  For each (currently) protected flag variable X, change
	it to a private member m_X and introduce an accessor function
	XFlag().  For backwards compatibility, also add a member X which
	shadows the value of m_X; this is public (to avoid naming
	convention warnings) but marked as deprecated.

	* More updates for stream-aware monitoring obo LAr
	* Disable ATLAS Ready filter for _comm project tags
	* Tag AthenaMonitoring-02-02-00-02

2016-04-09 Peter Onyisi <ponyisi AT cern.ch>
	* Reintegrate branch 02-01-25-branch:
	* Update stream-aware monitoring and reenable by default
	* Tag AthenaMonitoring-02-02-00-01

2016-04-04  scott snyder  <snyder@bnl.gov>
	* Add flag functions from AthenaMonitoring-02-03-00, to allow
	monitoring packages to be compatible with both r20 and r21.
	* Clean up a couple warnings.

2016-02-24 Peter Onyisi <ponyisi AT cern.ch>
	* Move histogram finalization to stop() instead of finalize()
	  in AthenaMonManager
	* Tag AthenaMonitoring-02-02-00

2015-12-30  scott snyder  <snyder@bnl.gov>
...
(Long ChangeLog diff - truncated)

	* Activate HI monitoring if doHIMon=True
	* Add command to switch off all monitoring (can then be reenabled as desired)
	* tag AthenaMonitoring-02-01-25

2015-10-23 Peter Onyisi <ponyisi AT cern.ch>
	* Includes Walter Lampl's fix for collision time monitoring
	* Doesn't count HVRAMPUP defects for LAr defect filtering obo B. Trocme
	* tag AthenaMonitoring-02-01-24

2015-08-18 Peter Onyisi <ponyisi AT cern.ch>
	* Fix Coverity 30958
	* set AtlasReady filter to run by default on express

	* Fix bug breaking menu-aware monitoring recognition
	* tag AthenaMonitoring-02-01-23

2015-05-30 Peter Onyisi <ponyisi AT cern.ch>
	* Fully enable menu-aware monitoring
	* tag AthenaMonitoring-02-01-21

2015-05-22 Peter Onyisi <ponyisi AT cern.ch>
	* Remove some unnecessary INFO messages
	* tag AthenaMonitoring-02-01-20

2015-05-08 Peter Onyisi <ponyisi AT cern.ch>
	* Enable IDPerfmon+IDDiMuMon
	* Disable stream aware monitoring by default
	* tag AthenaMonitoring-02-01-19

2015-05-05 - Yuriy Ilchenko
	* Lumi methods return guard values if information invalid
	* tag AthenaMonitoring-02-01-18

...
(Long ChangeLog diff - truncated)

2015-04-28 Thijs Cornelissen <thijs.cornelissen@ cern.ch>
	* Disable IDPerfMon+IDDiMuMon
	* tag AthenaMonitoring-02-01-16
2015-04-27 Peter Onyisi <ponyisi AT cern.ch>
	* include Trigger Translator Simple tool
	* tag AthenaMonitoring-02-01-15

2015-04-24 Walter Lampl <walter.lampl@ cern.ch>
	* BadLBFilterTool.py: Fix Copy-paste error, default DB instance CONDBR2
	* tag AthenaMonitoring-02-01-14

	* python/DQMonFlags.py re-enable MuonTrackMon by default
	* tag as AthenaMonitoring-02-01-13-03

run MET monitoring even if doMissingET is false (but doJetMissingETTag must be true) (AthenaMonitoring-02-01-13-02)

	* run MET monitoring even if doMissingET is false (but doJetMissingETTag must be true)
	* Tagged as AthenaMonitoring-02-01-13-02 (accidental -01 tag)

2014-10-20 David Quarrie <David.Quarrie@cern.ch>
	* cmt/requirements
		Specify the required ROOT components for cmake (transparent to CMT)
	* Tagged as AthenaMonitoring-02-01-13

2014-10-07 Peter Onyisi
	* merge changes from AthenaMonitoring-02-01-09-branch

2014-09-23 Walter Lampl <walter.lampl@ cern.ch>
	* don't run METMonitoring if rec.doMet is false
	* tag AthenaMonitoring-02-01-12

2014-09-11 Peter Onyisi

	* Merge change from AthenaMonitoring-02-01-09-branch
	* Add enableLumiAccess flag to suppress all lumi access if desired
	* tag AthenaMonitoring-02-01-11

2014-08-18  scott snyder  <snyder@bnl.gov>

	* Tagging AthenaMonitoring-02-01-10.
	* AlgTool -> AthAlgTool; Algorithm -> AthAlgorithm.