Tim Martin authored 5 years ago and Walter Lampl committed 5 years ago

Modern CA configuration inside newJOtest.py -> TriggerConfig.py
Old random-python-everywhere configuration inside full_menu.py

Fix warnings/errors flagged by `flake8`. Mostly unused variables/imports
or stylistic code problems.

On kernels with Yama enabled, ptrace may not work by default on processes
which are not decendants of the tracing process.  Among other things, that
causes the way we attach the debugger to fail.  However, we can disable this
on a per-process basis.  So do that when we initialize Athena.

See https://www.kernel.org/doc/Documentation/security/Yama.txt and prctl(2).

In order for an algorithm implemented in python to function, setup() must have
been called on its Configurable during initialize().  In the old configuration,
the Atlas AppMgr in AthenaCommon does this for all Configurables.  But with the
new configuration, we're using the Gaudi AppMgr directly, which does not
do this.  So in createApp, test to see if we're adding any python algorithms,
and if so, call setup() on them directly.

When doing this, be careful not to fail if AthenaPython is not available.

In printProperties(), print the properties in sorted order.

 - Fix flag testing in python 3.
 - Add option to loadAllDynamicFlags to suppress the annoying output.
 - Fix a typo in an error message.
 - Break out the conditions algorithm printing from printConfig
   into a separate function, so that we can request printing just that
   part of the configuration.  Allow including information on properties.
   

Fix references to func_name/func_code for python3.

Initial python3 port.  Not intended to be complete yet; only that required
for basic athena/configuration jobs.

- use lazy string formatting in logging calls
- some Python3 fixes
- remove print statements

Emmanuel Le Guirriec authored 6 years ago and Adam Edward Barton committed 6 years ago

Make tools private in
- InDetDetailedTrackSelectorTool.cxx
- TrackSummaryTool.cxx
- KalmanVertexOnJetAxisSmoother.cxx
- TrkVKalVrtFitter.cxx

Create Cfg methods for new config

Fix a typo in the documentation.

ComponentAccumulator: Introduce primary component instead of returning tuples. Adjusting (some) of the existing new-style configurations

ComponentAccumulator: Add doc-strings for setPrivateTool and popPrivateTool, move check for dangling private tool(s) to __del__