SealSvc does not have any useful function any more

Missing find_package for CLHEP.

Marcin Nowak authored 4 years ago and Walter Lampl committed 4 years ago

IgnoreInputFileBoundary flag had no use and no plans for use.
MetaDataSvc::prepareOutput(stream) is a new version of prepareOutput()
that should work for parallel streams (metadata tools need to be adapted
still)

Andrii Verbytskyi authored 4 years ago and Frank Winklmeier committed 4 years ago

Replaced the  FourVector:point3d().x() and similar methods with FoutVector::position().x() and similar

Liaoshan Shi authored 4 years ago and Walter Lampl committed 4 years ago

- Built full geometry model to get MBTS
- Adapted to the new Run2 geometry hierarchy
- Completed the CLHEP to Eigen migration
- Migrated to standalone GeoModelKernel library

Fixed the issue in AA-6

StatusCodeSvc is deprecated. Remove the corresponding RecFlag and all
its references.

Updates for python 3 compatibility.

This was just a best guess to what should be done here, hopefully I was not
too much off the mark. ;-)

Updates for python 3 compatibility.
Enable flake8 checking and fix warnings.

Updates for python 3 compatibility.
Enable flake8 checking and fix warnings.

Fixed the issue in AA-5

At the same time simplified the CMake configuration a tiny bit as well.

The rotation angle and shift of MDT BMG chambers were not properly
printed because the center of BMG chambers are not aligned with
the sector center in XY-plane. This patch corrects for that
and return a rotation angle to the next sector if the angular separation
of the chamber and the next sector center is less than half of the
sector open angle.

move remaining client code to use classes from PixelReadoutGeometry, remove duplicates from InDetReadoutGeometry

clang warnings:
  - Remove unneeded #define private.
  - Fix typo in qualityString(); was calling wrong method.
  - Fix arg-passing problem in JetCollectionSettingsButton::Imp::createMaterial
    (int used for a float arg)
  - Remove MissingEtCollHandle::Imp::collHandle.  Was unused and anyway
    just called itself.

clang warnigns:
  - Remove unneeded #define private.
  - Unused variables.

clang warning: struct/class mismatch.

clang warning: unused private data member.

clang warnings:
  - unused variables
  - unneeded #define private
  - comparing address of a references to nullptr.

clang warnings:
 - missing override keywords
 - unused variables.
 - string conversion.

 - useless comparison will nullptr
 - unused variables
 - typeid with side effects
 - string conversion

In the "new packaging" the external is now called like that...

The `TestPolicy` dependency stems mostly from the automatic `requirements`
to `CMakeLists.txt` file migration. In cmake builds, the TestPolicy
package is mostly useless apart from a few header files. So most
packages do no need this dependency anymore.

The changes belong to a large campaign aimed to clean up Athena code from incidents wherever possible.
These include:
  * Dropped redundant includes to FileIncident.h
  * Cleaned up all references to the UpdateOutputFile, BeginFile and EndFile incidents which are never fired
  * DecisionSvc cleaned up from the redundant inheritance from IIncidentListener
  * ByteStreamEventStorageInputSvc cleaned up from the redundant private service handle to IncidentSvc