Updates included:
  isolation hypo tool configuration so that all properties are set correctly,
  allow muon event view creator to be able to turn off link to parent view (it's not needed in this case) to be able to run the same ID tarcking sequence in two different views within same chain,
  muon isolation sequence set to pick up correct muon containers and run precision ID tracking.

Heather Russell authored 5 years ago and Adam Edward Barton committed 5 years ago

Conflicts:
	Trigger/TrigValidation/TrigUpgradeTest/test/test_trigUpgr_slice_mu_build.sh
	Trigger/TriggerCommon/TriggerMenuMT/python/HLTMenuConfig/Menu/LS2_v1.py

Since for MC we start from RDO input, we don't need to run the BS to RDO decoding to run. Also swtiching off the checking for ID related BS conversion if we aren't reading BS input. Fixes the problems reported in ATR-19763.

Mark Andrew Owen authored 5 years ago and Frank Winklmeier committed 5 years ago

Add RoI seeded decoding to CSC BS deocding alg and unify CSC data preparation between L2 and EF in athenaMT setup.

Changes made:
- CscRawDataProvider has options needed to do decoding based on input RoIs (needed for use in trigger).
- TrigL2MuonSA/CscDataPreparator: added option to turn off the actual decoding. Also cleaned the code slightly.
- MuonSetup: Turn on RoI based decoding for CscRawDataProvider in RoI mode. Turn off decdoing in the L2 CscDataPreparator and run instead the offline decoding algorithms. Add CSC data to EF muon data verifier and no longer run offline decoding algorithms.

Scott Snyder authored 5 years ago and Vakhtang Tsulaia committed 5 years ago

Migrate CaloCellCollector from CaloNoiseTool to CaloNoise conditions object.
Remove a bad const_cast in passing.

We never actually use the MuidCaloEnergyMeas tool in the trigger, since we don't have access to calo information at the muon trigger level. Any algorithms/tools that need it we anyways configure such that this tool is disabled.
Removing this from the trigger configuration so some cleanup of the offline code can proceed in atlas/athena!23065.

Mark Andrew Owen authored 5 years ago and Adam Edward Barton committed 5 years ago

TgcRawDataProvider: simplify decodoing of full event by using convert() method of data provider tool, where the ROB vector is loaded with the same logic I removed here

Savanna Shaw authored 5 years ago and Adam Edward Barton committed 5 years ago

Includes proper configuration of EF muon isolation algorithm and hypo,
setup of proper sequence to run ID tracking around muons and calculate the
isoltion, and addition of the relevant pieces to the menu.

Scott Snyder authored 5 years ago and Adam Edward Barton committed 5 years ago

Fixes test failure in master.

Enable flake8 plugin to check for Python3 compatibilty and additional
checks on printout/logging. Fix offending code in HLTMenuConfig.

Changes made:
- TgcDataPreparator: Add flag to turn off actual data decoding and remove some unused variables / functions.
- MuFastDataPreparator: Make TgcDataPreparator private tool
- MuCalStreamerTool: Remove unused hash list and handle to TgcDataPrepartor.
- MuonSetup: Modifications so Tgc data prep runs at L2 step and is reused by EF.

Fix bug where combined muon reco sequence was not being called, and fix the verifiers to get the right information from previous views in the full scan vs RoI chains.

I also fixed a couple of bugs:
- L2MuonSA CscDatPreparator was not getting passed the CSC raw data preparator (which I think meant no CSC data was seen at L2)
- The way to set the RoIs property for the data decoding run for EF was always setting the RoIs to FSRoI, that is now fixed

Disable the per-event summary output in the MuonSegmentFinder.

The following changes have been made:
- TrigL2MuonSA/MdtDataPreparator: Add a new flag to disable the decoding of the MDT data. Also disable the relevent tools and data-handles when the decoding is disabled. I also removed m_storeGateSvc, which wasn't used anywhere in the code.
- TriggerMenuMT/python/HLTMenuConfig/Muon/MuonSetup.py: Load the 'standard' muon data prep algorithms in the muFastRecoSequence and add the MDT algorithms to the sequence. The configuration of the MdtDataPreparator is changed to not run the decoding. In the EF sequence, I added a ViewDataVerifier to twll the view that it should expect the MDT PRDs to be available from the previous L2 steps and removed the MDT data preparation algorithms. A special case was needed here for full-scan. Some of this is a bit ugly, but should be improved when we migrate to the new JO.

Also update the reference for the muon menu test

This is a first attempt to setup a full scan muon chain.
At the moment it just runs a single muon full scan chain (the hypos need updating to handle properly muX_muYnoL1 type chains): mu6noL1.

The unit ctests MuonDataDecodeTests and MuonDataDecodeTests_Cache run a diff with a reference file which has been updated here to reflect the decoupling of the BS conversion from the RDO-PRD process for the MS CSCs. The BS decoding is now done directly in the trigger algorithms. Old, unneeded, comment lines have also been removed from config file MuonPrdProviderToolsConfig.py from the MuonRecExample pkg and the MuonSetup.py file from the TrigUpgradeTest pkg

This adds the combined muons to the mu.with.views tets, and also fixes a bug with the input RoIs in that test.
Also updates both muon tests to run over different events so that the combined muon reco actually runs in at least one event (and correspondingly updates the reference for the menu test).

Fix a bug in trying to write collections with the same name.
Changed which events the muon menu tests runs over so that all parts of the chains actually run in the test (and updated the reference accordingly).

In preparation for the migration of the Athena code to the multi-threaded AthenaMT, remove the (scheduler-unsafe) dependency of the TGC RDO->PRD tool on the existence of the RDOs which are in some cases produced from the BS using a decoding function called by the RDO-PRD process itself.

The RawDataProviderTool which can perform the BS decoding is removed from the Muon Spectrometer TGC RDO->PRD convenience tool and can now be used directly by trigger and offline in a similar manner. Changes have been made to the tigger validation unit tests to reflect these changes.

Former-commit-id: 296a5f56

Former-commit-id: 957c48a9