Changes to run with CMSSW
This is a new version of !70 (closed) which has a re-written history.
From previous MR by DR:
""
This MR includes all changes made during last week's Hackathon:
- Remove SCDAQ functionality that creates special directories for hltd/CMSSW
- Fix a few bugs to allow processing with CMSSW
It requires some cleanup (notably I'll rewrite the history to make things clearer) and may get some more edits.
""
Edited by Thomas Owen James
Merge request reports
Activity
Filter activity
assigned to @tjames
mentioned in merge request !70 (closed)
Before looking at this in depth:
- Did you confirm that this here has all the changes (and not more than) the one in !70 (closed) had?
- Was this branch tested?
- I've put several TODOs in the code. Are you going to do them or should I?
- There's commented code in multiple places, are you going to clean that up or should I?
- Resolved by Emilio Meschi
- Did you confirm that this here has all the changes (and not more than) the one in !70 (closed) had?
- Yes I just went through and confirmed
- Was this branch tested?
- Not since the rebase - I can do that now, but maybe smarter to wait for the TODOs to be done to avoid testing twice
- I've put several TODOs in the code. Are you going to do them or should I?
- Depends if you have time to do them - if not I can go ahead, let me know (also if you have specific implementations in mind)
- There's commented code in multiple places, are you going to clean that up or should I?
- I can do that easily now (DONE)
Edited by Thomas Owen James - Did you confirm that this here has all the changes (and not more than) the one in !70 (closed) had?
requested review from @pzejdl
requested review from @matteomi
requested review from @rardino
- Resolved by Emilio Meschi
added 1 commit
- aadaa96f - put write_EoR_file in outputfilehandler destructor as per Dinyar's "todo".
- Resolved by Emilio Meschi
- Resolved by Emilio Meschi
Hi @dinyar I believe I have addressed all your todos either by doing them or by seeking clarification. I would really like to not drag this out into the new year.
Hi @tjames . I believe by my approving the merge request I was implicitly giving the go-ahead to merge
Please register or sign in to reply