An issue with the `CfgGetter` syntax for these two packages
was found in the `20.20.X.Y-VAL` nightlies. This commit
pulls in the fixes from `Charginos-00-02-05` and `Gauginos-00-02-03`.
See the discussions in ATLMCPROD-4978. This is also
relevant to ATLASSIM-3401.


Former-commit-id: 00e37ab1849d0225a1d5ae2d1511eb228175271e

Two classes in the `Simulation/Tools/HitAnalysis` package
had minor build warnings about the order of initialization.
This commit should fix these.


Former-commit-id: 1eb7bd77ab4f592b17fb311fe7f738ef23f2d42c

See ATLASSIM-3424


Former-commit-id: be4292e9cb253d4919ea18e86ab62fa07fe8c30b

In the previous commit a `/` character was accidentally dropped from
the lines which set `athenaCommonFlags.FilesInput`.


Former-commit-id: 83860939cea067ad4a2405f8f077c1ab064d0cff

Fixing syntax errors in CharginosDb.py. Part of the fixes for
ATLASSSIM-3401.


Former-commit-id: 16ff21d4f408cca2c25e6d331459540f8271c7dd

Fixed a bug in FastCaloSimParamAction which prevented us from using values for maxRadiusLAr threshold other than 1mm.


Former-commit-id: 97d8351d7ea5ad20a8c6e4c83f915aaedd9c410b

Former-commit-id: 5a5a4eb09b53adccadbe62f6f706a49635484be4

Former-commit-id: aaf1b2b7fa6cd4fb01d521528194e24509f4f09c

Prefer to use `simFlags.TruthStrategy.TruthServiceName()` rather than
`simFlags.TruthService.get_Value()` to set Truth Service name.

This should fix issues seen as part of ATLASSIM-3378


Former-commit-id: e1db4d08

This command is set by default, so no need to set it in `PyG4AtlasAlg.py`


Former-commit-id: 3f5a46db89bf053ece320d5c85891b71e4f2181f

When we moved away from using FADS to set the G4 verbosity level we
switched to using a `SimFlag` to set a property of `G4AtlasAlg` and
`G4TransportTool` which then runs the command strings supplied via
`G4UIManager` interface. Although the configuration code attempted
to set the `SimFlag`, it was already locked and so nothing was set.
By adding the verbosity setting command as the default value of the
`SimFlag` it should always be supplied to `G4AtlasAlg` and
`G4TransportTool`.


Former-commit-id: 098c877dd4814ecc202c42e36b6fb6fa2272abd9

One CfgGetter method was added to the dictionary twice
and another was missing. Part of the fixes for ATLASSSIM-3401.


Former-commit-id: aba6f391

In order to conserve lepton number, chargino decays into leptons plus
neutralino should be to e+, nu_e, neutralino rather than just e+,
neutralino for example. This is a further fix for ATLASSIM-3401.


Former-commit-id: 84da4bc6

After discussions on the merge request we decided it was best to copy
the pile-up input files to the local disk before running digitization
test jobs.


Former-commit-id: 101daf92

Former-commit-id: c3763f2a

Changing the way calo hit merging schemes are handled by
`FastCaloSimParamAction`. This set of changes makes all
of the hit merging cuts configuratble via
`FastCaloSimParamActionTool`. See ATLASSIM-3398.


Former-commit-id: 5217eedabe46905d0a08faa48f969ab2ba48bf12

HitAnalysis and CaloHitAnalayis use floats for the TTC
commenting out the truthVtxBarcode in CaloHitAna
removing old TTC variables from the outputs
Updated scripts for shape parametrizaton
Fixed CaloHitAna using too much memory
Further changes to CaloHitAna:
- commenting out one_truth and truthcollection
- commenting out new_truthVtxBarcode->push_back(..)
- changed TTC variables to float


Former-commit-id: 983a24b4

Deleted pointers in `TFCSPCAEnergyParametrization.cxx` and
`TFCS1DFunctionHistogram.cxx`.
Fixing normalization issue after smart rebinning in
`TFCS1DFunctionHistogram`.


Former-commit-id: 13178651b20f9120311020ab3d7530c4d042f53b

Adding Jana's changes to CaloHitAna. Commented out one_truth and truthcollection and new_truthVtxBarcode->push_back(TruthVtxBarcode->at(truth_i)). Changed TTC variables to be floats instead of double.


Former-commit-id: b0e7d97f523742a50f1f9a8fdeb871fc5142d2cd

Former-commit-id: 3f8e02fe4e6bc403c25c3090f3762f26071b33d8

Drop the ZH prefix from the `FCS_StepInfoCollection` names.


Former-commit-id: a7dfce31

Rather than writing out both `ISF_FCS_Parametrization::FCS_StepInfoCollection_ZHEventSteps`
and `ISF_FCS_Parametrization::FCS_StepInfoCollection_ZHMergedEventSteps` - only the
latter should be written out.


Former-commit-id: 1a1d6c97

Former-commit-id: f1ad59fa4d4d4c1eed51f8df689c1173cddec426

`G4Step` owns the pointers to the pre and post step point `G4StepPoints`
objects and deletes any existing objects as part of the
`G4Step::SetPreStepPoint(...)` and `G4Step::SetPostStepPoint(...)` calls.
Therefore deleting those pointers just before causes a double-delete
when the methods are called. This causes random crashes during the
simulation job.


Former-commit-id: 3c73552f

Two missing `break` statements were causing the `m_detectormap`
member variable to be filled incorrectly.

It would be nicer to fill `m_detectormap` at the start of each job, rather
than on-the-fly, but this would require a major re-write.


Former-commit-id: a65b4d1e

Former-commit-id: 73909e27fa22948b8707ce1a3b4cd4aa37f54eec

Former-commit-id: 172b33eb

Former-commit-id: bf4df24456f129bd0e40684f26e9545f4bc02829

Renaming `NeutralinoToPhotonPlusGravitino` tool to
`NeutralinoToPhotonGravitino` to match the naming convention used
by the other decay tools.


Former-commit-id: f83683046b5c63e521f520b01d18d4c19d9c51ba

`ISF_FastCaloSimParametrization_DigiTilePreInclude.py` is identical
to `ISF_FastCaloSimParametrization_DigiPostInclude.py`. The configuration
should be done at the postInclude stage, so removing the preInclude.


Former-commit-id: 17fbcfa1

In ATLASSIM-3399 it was noted that zero event lumiblocks in `JobMaker`
lists of dictionaries defined in `configLumi` preIncludes are
interpreted as one event lumiblocks when they are passed to the
C++. This commit blocks zero event lumiblocks from being added to the
`RunAndLumiOverrideList` `DigitizationFlag` which is used to configure
the services used at runtime.


Former-commit-id: 1beb9bae3e2a66d2ddcc23ecd6c626caed9bdd92

This commit pulls in changes from `HitAnalysis-00-02-04` which add
classes to plot New Small Wheel SimHits and add some lines of
`GeoModelSvc` configuration to the job options to allow them to run
on NSW geometries when these lines are uncommented.


Former-commit-id: cda9f4917f943ea7983c9dbeeb45f956d67fc62a

All Simulation jobs use the ISF TruthSvc now, so code configuring
the old-style TruthStrategies has no effect. Decays in the
Calorimeter are saved by default anyway in MC15 and MC16.


Former-commit-id: 003fc59f4dde9623db8a7700f17160d7a4e05f37

In 19.2.X.Y when GMSBIndex=1 was set then GMSB Neutralinos would be decayed
to a photon and a Gravitino within Geant4. This functionality was lost
during the configuration migration for MC16. This set of changes adds it back.
See ATLASSIM-3401.


Former-commit-id: f5d01578

The option to decay Charginos to a pi+/pi- and a Neutralino within Geant4
existed in 19.2.X.Y, but was lost during the configuration migration
for MC16. This set of changes adds it back and in addition adds the
ability to have the Chargino decay to an e+/e- and a Neutralino or a
mu+/mu- and a Neutralino, as requested in ATLASSIM-3401.


Former-commit-id: f05abf81494977c927073280fd5ed526fffd5639

Former-commit-id: a095161f5b0d7f210374308fc5983be2ea8c888c

This flag will enable all pile-up premixing specific configuration for digitization. For now it enables
AddCaloDigi flag.


Former-commit-id: ec5e161f2991a36647bcbce5f71e18442896f39f

Former-commit-id: 925ff30ca80b0183141b1a9799c12a29a34292dc

Now that `IRegionCreator` tools are private ToolHandles owned by
`DetectorGeometrySvc` then extra tools should be added after the main
configuration. For this reason I've renamed the related preInclude files
to be postIncludes. `preInclude.Cavern.py` and `preInclude.ScoringVolumeKiller.py`
had to be split into separate pre and post includes. Part of the changes
for ATLASSIM-3379.
It would be nice to find a way to decide whether or not to add
`MuonPhysicsRegionTool` to `DetectorGeometrySvc.RegionCreators` within
`G4AtlasServicesConfig.py`.


Former-commit-id: 667ad53e9cd87b13c19026eecbbac6ad9a046132

`IRegionCreator` tool configuration are tweaked in a number of job
options, so these job options had to be updated to reflect the fact
that the tools are now private rather than public.


Former-commit-id: 442d93bf