Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • T ttbbRun2Bamboo
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 3
    • Issues 3
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Sebastien Wertz
  • ttbbRun2Bamboo
  • Merge requests
  • !21

Fix CP3SlurmUtils issues; various other changes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Sebastien Wertz requested to merge variousChanges into master Aug 10, 2020
  • Overview 8
  • Commits 9
  • Changes 10

This mainly solves the non-ideal situation with the CP3SlurmUtils package. After this is merged you'll have to:

  • upgrade bamboo
  • install CP3SlurmUtils using python -m pip install -i https://test.pypi.org/simple/ CP3SlurmUtils (inside of your bamboo venv)
  • remove the part in your PYTHONPATH pointing to my or Kyle's CP3SlurmUtils folder
  • do mkdir ~/.config/CP3SlurmUtils; ln -s (abs path to)/ttbbRun2Bamboo/config/defaults.cfg ~/.config/CP3SlurmUtils

Also, you can do the following to avoid having to specify the .ini file each time you call bambooRun: ln -s (abs path to)/ttbbRun2Bamboo/config/bamboo.ini ~/.config/bamboorc

Other changes include (mainly):

  • Remove duplicate application of b-tag SF patches in the controlPlotter. Instead, there is now a command-line argument to select which ones to use.
  • Better handle the case when we run on both the 4FS and 5FS samples (note: for now the samples_template.yml was changed to make sure the ttB part is only taken from the 4FS samples): the overlap is removed before running plotIt (in the controlPlotter only for now!!)
  • With topNanoAOD the branch storing the PS weights has changed
  • QCD (renormalization/factorization scales): instead of taking the envelope of the 7-point variation, create two separate uncertainties for muR/muF. Further checks might be needed to compare with the simultaneous variation of muR and muF.
  • Added a script to check the PS or QCD weights in nanoAOD files, and thus:
  • I've updated the list of samples with buggy PS or QCD weights in /t3home/swertz/bambooDev/ttbbRun2Bamboo/config/buggyThSyst.yml. It's also possible some remaining issues in the QCD weights (order of weights different from assumed one) remain: TODO.

Feedback welcome!

Edited Aug 11, 2020 by Sebastien Wertz
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: variousChanges