Add preliminary smart container list, throws a warning not an exception
This is a fix for !25104 (merged), which broke several ART tests.
The problem was that we added a new smart collection for VR track jets, which everyone used to add to AllVariables
. Of course AllVariables
is disallowed for collections with smart collections (at least in some derivations), so adding a smart collection broke several of our bigger derivations.
With this MR, the SlimmerHelper
will check for the offending collection in PreliminarySmartCollections
. If the collection is listed as a "preliminary" smart collection it will just throw a warning.
I think this solution is the least evil of several options:
- I can't validate every derivation to make sure this smart collection works for them. This is something that will have to be up to the derivations clients.
- I don't want to break anyone's derivation, and unfortunately several derivations are broken right now.
- I don't want to keep adding VR track jets to
AllVariables
: most people need very few of the variables we're saving there.
I'm guessing some people would opt for a more draconian approach where we simply leave the derivations broken and leave it up to the derivation contacts to fix them. That sort of decision seems above my pay grade and beyond the timescale where we'd want to have the ART tests fixed (maybe a conversation in the derivation coordination meeting would be appropriate at some point).
Merge request reports
Activity
added 21.2 Derivation review-pending-level-1 labels
This should be of interest to @boeriu and @jburr. I'm also going to ping @jcatmore since he sometimes has opinions about how heavy-handed we should be with smart collections.
I'll also go ahead and mark this as urgent (sorry there have been so many recently) and RC Attention Required since we probable do need this fixed soon.
added RC Attention Required bugfix urgent labels
CI Result SUCCESS AnalysisBase AnalysisTop AthAnalysis AthDerivation externals cmake make required tests optional tests Full details available at NICOS MR-25202-2019-07-29-22-20
AnalysisBase: number of compilation errors 0, warnings 0
AnalysisTop: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 2
AthDerivation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 40130] CI Result SUCCESS AnalysisBase AnalysisTop AthAnalysis AthDerivation externals cmake make required tests optional tests Full details available at NICOS MR-25202-2019-07-30-00-33
AnalysisBase: number of compilation errors 0, warnings 0
AnalysisTop: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 2
AthDerivation: number of compilation errors 0, warnings 11
For experts only: Jenkins output [CI-MERGE-REQUEST 40128] added review-approved label and removed review-pending-level-1 label
mentioned in commit 6431c765
added sweep:ignore label