This is a fix for !25104 (merged), which broke several ART tests.
The problem was that we added a new smart collection for VR track jets, which everyone used to add to AllVariables
. Of course AllVariables
is disallowed for collections with smart collections (at least in some derivations), so adding a smart collection broke several of our bigger derivations.
With this MR, the SlimmerHelper
will check for the offending collection in PreliminarySmartCollections
. If the collection is listed as a "preliminary" smart collection it will just throw a warning.
I think this solution is the least evil of several options:
AllVariables
: most people need very few of the variables we're saving there.I'm guessing some people would opt for a more draconian approach where we simply leave the derivations broken and leave it up to the derivation contacts to fix them. That sort of decision seems above my pay grade and beyond the timescale where we'd want to have the ART tests fixed (maybe a conversation in the derivation coordination meeting would be appropriate at some point).
Status | Pipeline | Created by | Stages | Actions |
---|---|---|---|---|
Stage: external |
Download artifacts
No artifacts found | |||
Stage: external |
Download artifacts
No artifacts found |