JetMomentTools: cleanup and enable flake8
Enable flake8 and delete two unused modules (JetCopyMomentsAlg,
JetMomentsConfigHelpers). Only install ROOT files into data area.
Merge request reports
Activity
This merge request affects 2 packages:
- PhysicsAnalysis/D3PDMaker/TruthD3PDMaker
- Reconstruction/Jet/JetMomentTools
Affected files list will not be printed in this case
Adding @goetz as watcher
added Analysis JetEtmiss Reconstruction master review-pending-level-1 labels
-
Athena AthSimulation AthGeneration AnalysisBase externals cmake make required tests optional tests Full details available on this CI monitor view
added review-approved label and removed review-pending-level-1 label
mentioned in commit 6c90307e
added sweep:ignore label
27 27 LINK_LIBRARIES ${Boost_LIBRARIES} ${FASTJET_LIBRARIES} ${ROOT_LIBRARIES} AsgTools CaloIdentifier xAODCaloEvent xAODJet GaudiKernel JetCalibToolsLib JetEDM JetInterface JetRecLib JetUtils PFlowUtilsLib PathResolver JetMomentToolsLib ${extra_libs} ) 28 28 endif() 29 29 30 #if( XAOD_STANDALONE ) 31 30 atlas_add_dictionary( JetMomentToolsDict 32 31 Root/JetMomentToolsDict.h 33 32 Root/selection.xml 34 33 LINK_LIBRARIES JetMomentToolsLib PFlowUtilsLib ) 35 #endif() 36 34 37 35 # Install files from the package: 38 atlas_install_python_modules( python/*.py ) 39 atlas_install_runtime( share/*.root ) -
As un-intuitive as it was, this is why ATLASRECTS-5854 is happening.
To clarify: I believe we should indeed only keep
atlas_install_data( share/*.root )in this file. But we need to update https://gitlab.cern.ch/atlas/athena/-/blob/master/Reconstruction/Jet/JetMomentTools/JetMomentTools/JetVertexTaggerTool.h#L110 to look for the file as"JetMomentTools/JVTlikelihood_20140805.root".Anybody willing to set up the MR?...
I reverted this change in !39340 (closed).
mentioned in merge request !39341 (merged)
