Use TrackingGeometryCondAlg everywhere when use_tracking_geometry_cond_alg is set

For some tools, the TrackingGeometryReadKey was not set under some circumstances, this should be fixed such that when the TrackingCommon Flag use_tracking_geometry_cond_alg is True, the TrackingGeometrySvc will not be used anymore

This merge request affects 12 packages:

• InnerDetector/InDetExample/InDetAlignExample
• InnerDetector/InDetExample/InDetRecExample
• MuonSpectrometer/MuonReconstruction/MuonRecExample
• PhysicsAnalysis/D3PDMaker/JetTagD3PDMaker
• Reconstruction/MuonIdentification/MuonCombinedBaseTools
• Reconstruction/MuonIdentification/MuonCombinedConfig
• Reconstruction/MuonIdentification/MuonCombinedRecExample
• Reconstruction/MuonIdentification/MuonCombinedTestTools
• Reconstruction/iPat/iPatRecExample
• Simulation/ISF/ISF_Tracking/ISF_TrackingTools
• Tracking/TrkAlignment/TrkAlignGenTools
• Tracking/TrkConditions/TrackingGeometryCondAlg

Affected files list will not be printed in this case

Adding @goetz ,@jchapman ,@amorley ,@wleight ,@sroe ,@rosati ,@jojungge as watchers

added Analysis InnerDetector JetEtmiss MuonSpectrometer Reconstruction Simulation Tracking master review-pending-level-1 labels

CI Result FAILURE (hash 2827e57c)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30847]

Hi @rlangenb,

there are CI failures

S:0 E: MuonCombinedAlg.MuonCombinedTool.MuonCombinedStacoTagTool                                                                         ERROR  MuonCombinedBaseTools/src/MuonCombinedStacoTagTool.cxx:30 (StatusCode MuonCombined::MuonCombinedStacoTagTool::initialize()): code FAILURE: m_tagTool.retrieve()
S:0 E: MuonCombinedAlg.MuonCombinedTool.MuonCombinedStacoTagTool                                                                         ERROR  AthenaBaseComps/AthenaBaseComps/AthCommonDataStore.icc:43 (StatusCode AthCommonDataStore<PBASE>::sysInitialize() [with PBASE = AthCommonMsg<AlgTool>]): code FAILURE: PBASE::sysInitialize()
S:0 E: ToolSvc                                                                                                                           ERROR  Error initializing tool 'MuonCombinedAlg.MuonCombinedTool.MuonCombinedStacoTagTool'

Can you please take a look?

Thanks, Volker (L1)

added review-user-action-required label and removed review-pending-level-1 label

mentioned in merge request !42128 (merged)

mentioned in merge request !42132 (merged)

Hi,

This error was a bit confusing:

S:0 E: ToolSvc  ERROR  Cannot create tool <AthenaConfiguration.ComponentAccumulator.ComponentAccumulator object at 0x7f1c50aacd50> (No factory found)

But the reason I guess is this:

kwargs.setdefault("TagTool", CombinedMuonTagTestToolCfg(flags))

You need to assign the tool itself to the property, not the CA.

added 1 commit

• 7d1bd2da - retrieving tool from ComponentAccumulator before assignment to property

Compare with previous version

This merge request affects 12 packages:

• InnerDetector/InDetExample/InDetAlignExample
• InnerDetector/InDetExample/InDetRecExample
• MuonSpectrometer/MuonReconstruction/MuonRecExample
• PhysicsAnalysis/D3PDMaker/JetTagD3PDMaker
• Reconstruction/MuonIdentification/MuonCombinedBaseTools
• Reconstruction/MuonIdentification/MuonCombinedConfig
• Reconstruction/MuonIdentification/MuonCombinedRecExample
• Reconstruction/MuonIdentification/MuonCombinedTestTools
• Reconstruction/iPat/iPatRecExample
• Simulation/ISF/ISF_Tracking/ISF_TrackingTools
• Tracking/TrkAlignment/TrkAlignGenTools
• Tracking/TrkConditions/TrackingGeometryCondAlg

Affected files list will not be printed in this case

Adding @goetz ,@jchapman ,@amorley ,@wleight ,@sroe ,@rosati ,@jojungge as watchers

added review-pending-level-1 label and removed review-user-action-required label

resolved all threads

CI Result SUCCESS (hash 7d1bd2da)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30993]

All threads are resolved, CI passed and the changes look fine, approving. Pienpen(L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 4f92d324

added sweep:ignore label