MuTagMatchingTool - Add explicit geometry dependence & resolve FPE

Hi @rlangenb,

while I tried to track down the FPE reported in ATLASRECTS-6139, I noticed that the MuTagMatchingTool locally retrieves the tracking geometry. Following the recipe for the other muon tools, I added the tracking geometry in this tool as well. I do not know which MR goes in first (this one or !42105 (merged)). In any case, I wanted to inform you that there is a new official geometry client.

The FPE reported in the ticket has been resolved.

Cheers, Johannes

Thanks for letting me know @jojungge, I was only checking q431 and if TGSvc.trackingGeometry() is being called, my celebration was apparently a little premature. @goetz, I'll try to adapt your debug tool to find detStore.retrieve(TrackingGeometry) instances.

Hi,

I found a second case where the Geometry is retrieved in class methods. Fix is on the way soon

mentioned in merge request !42132 (merged)

changed title from WIP: MuTagMatchingTool - Add explicit geometry dependence to WIP: MuTagMatchingTool - Add explicit geometry dependence & resolve FPE

changed the description

marked this merge request as ready

This merge request affects 1 package:

• Reconstruction/MuonIdentification/MuonSegmentTaggers/MuonSegmentTaggerTools

This merge request affects 3 files:

• Reconstruction/MuonIdentification/MuonSegmentTaggers/MuonSegmentTaggerTools/CMakeLists.txt
• Reconstruction/MuonIdentification/MuonSegmentTaggers/MuonSegmentTaggerTools/src/MuTagMatchingTool.cxx
• Reconstruction/MuonIdentification/MuonSegmentTaggers/MuonSegmentTaggerTools/src/MuTagMatchingTool.h

Adding @goetz ,@rosati ,@wleight ,@jojungge as watchers

added Reconstruction master review-pending-level-1 labels

CI Result FAILURE (hash 6a7be3d3)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30914]

Hi, there is an error in the q221xAODDigestTest-test,

CI_TEST/CI_TEST_RUNNER: TEST FAILURE: q221xAODDigestTest returned code 2

it seems related to the CoreDumpSvc package,

HITtoRDO 17:09:08 CoreDumpSvc          INFO Handling signals: 11(Segmentation fault) 7(Bus error) 4(Illegal instruction) 8(Floating point exception)

Could you please check that?

Thanks, Marianna (L1)

added review-user-action-required label and removed review-pending-level-1 label

Hi @jojungge, @rlangenb,

this changeset changes the reco output. Is this expected? Shouldn't the MR just change the retrieval mechanism of the tracking geometry?

Best, Nico

marked this merge request as draft

added 117 commits

• 6a7be3d3...d75161d3 - 116 commits from branch atlas:master
• b0f816f9 - Merge branch 'master' of ssh://gitlab.cern.ch:7999/atlas/athena into ATLASRECTS-6139

Compare with previous version

added 1 commit

• b9a26d22 - Revert "Fix FPE reported in ATLASRECTS-6139"

Compare with previous version

added 1 commit

• cbc2d650 - Overseen that the cosphi is the primary number available. Let's use this implementation

Compare with previous version

marked this merge request as ready

This merge request affects 1 package:

• Reconstruction/MuonIdentification/MuonSegmentTaggers/MuonSegmentTaggerTools

This merge request affects 3 files:

• Reconstruction/MuonIdentification/MuonSegmentTaggers/MuonSegmentTaggerTools/CMakeLists.txt
• Reconstruction/MuonIdentification/MuonSegmentTaggers/MuonSegmentTaggerTools/src/MuTagMatchingTool.cxx
• Reconstruction/MuonIdentification/MuonSegmentTaggers/MuonSegmentTaggerTools/src/MuTagMatchingTool.h

Adding @goetz ,@rosati ,@wleight ,@jojungge as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash cbc2d650)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 30982]