Draft: StoreGate: WriteDecorHandle consistency check.

Add a check to WriteDecorHandle that the provided AuxElement is actually a member of the declared container.

(For now, don't do the same thing for ReadDecorHandle, as that would add extra overhead.)

added full-integration-tests full-unit-tests labels

This merge request affects 1 package:

• Control/StoreGate

This merge request affects 8 files:

• Control/StoreGate/StoreGate/ReadDecorHandle.icc
• Control/StoreGate/StoreGate/WriteDecorHandle.h
• Control/StoreGate/StoreGate/WriteDecorHandle.icc
• Control/StoreGate/StoreGate/exceptions.h
• Control/StoreGate/share/exceptions_test.ref
• Control/StoreGate/src/exceptions.cxx
• Control/StoreGate/test/WriteDecorHandle_test.cxx
• Control/StoreGate/test/exceptions_test.cxx

Adding @ssnyder as watcher

added 23.0 Core review-pending-level-1 labels

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

CI Result FAILURE (hash 94302cb4)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 69011]

Could you please have a look at the failed tests?

Jason (L1)

added review-user-action-required label and removed review-pending-level-1 label

Adding this check is revealing problems that should be fixed...

marked this merge request as draft

removed review-user-action-required label

Hi @ssnyder should we open a few JIRA tickets?

I'm working on a first set of fixes.

mentioned in merge request !62205 (merged)

mentioned in commit a1bfab34

mentioned in merge request !62278 (merged)

mentioned in commit 427198c7

mentioned in merge request !62377 (merged)

mentioned in merge request !62378 (merged)

mentioned in commit 5bbdb3d8

mentioned in commit 2e706c7f

mentioned in merge request !62414 (merged)

mentioned in commit 1204bce3

mentioned in merge request !62513 (merged)

mentioned in merge request !62514 (merged)

mentioned in commit 375ee14e

mentioned in commit d6b8ea03

mentioned in merge request !62822 (merged)

Superceded by !62822 (merged).

closed