Skip to content
Snippets Groups Projects

Redesign of job options management

Merged Marco Clemencic requested to merge clemenci/Gaudi:joboptssvc-redesign into master
  • introduce a namespace to hold interfaces: Gaudi::Interfaces
  • introduce a new interface Gaudi::Interfaces::IOptionsSvc
  • deprecate IJobOptionsSvc methods
  • rewritten JopOptionsSvc to implement the new interface and provide implementation of IJobOptionsSvc through the new methods
  • modified ISvcLocator to provide quick access to the default implementation of Gaudi::Interfaces::IOptionsSvc
  • modified all components bases to use the new interface
  • bind properties to the option service (at initialize)
    • IOptionsSvc::set directly sets the actual property
    • IOptionsSvc::get returns the value of the actual property (as string) even if not originally set from option files
  • added options to lazily set global defaults
    • JopOptionsSvc().GlobalDefaults = [(r'.*\.OutputLevel$', '5')] can replace MessageSvc().OutputLevel = 5

Note: includes !759 (merged)

Edited by Marco Clemencic

Merge request reports

Pipeline #1817221 passed

Pipeline passed for 1ab545df on clemenci:joboptssvc-redesign

Approval is optional

Merged by Charles LeggettCharles Leggett 4 years ago (Jul 28, 2020 5:18pm UTC)

Merge details

Pipeline #1830968 passed

Pipeline passed for 4347888e on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Marco Clemencic changed the description

    changed the description

  • added 1 commit

    • 8d379310 - Fixed typo in CMake option name

    Compare with previous version

  • added 1 commit

    • 0e3526bc - Fixed typo in CMake option name

    Compare with previous version

  • added 1 commit

    • 9c38c32c - fixup! Rewired JobOptionsSvc in terms of a simple map string->string

    Compare with previous version

  • Marco Clemencic marked as a Work In Progress from clemenci/Gaudi@9c38c32c

    marked as a Work In Progress from clemenci/Gaudi@9c38c32c

  • Gerhard Raven mentioned in issue #9

    mentioned in issue #9

  • Gerhard Raven resolved all discussions

    resolved all discussions

  • Marco Clemencic unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Marco Clemencic added 16 commits

    added 16 commits

    • 9c38c32c...58146ecb - 2 commits from branch gaudi:master
    • 323cbc1d - Drop obsolete GaudiMT
    • de692560 - Drop unused GaudiMTTools
    • 35a59d7f - Demoted a few AvalancheSchedulerSvc messages
    • 88fab112 - Fixed typo in CMake option name
    • d516f8f2 - Rewired JobOptionsSvc in terms of a simple map string->string
    • 1329410b - Made OptionsSvc lookup case insensitive
    • 01bba39d - Added easy access to OptionsSvc implelmentation
    • 7d114654 - Improve OptionsSvc interface
    • d2d54a03 - Replaced Alg/Tool/Svc setProperties with PropertyHolder method
    • 62e10baa - Removed use of JobOptionsSvc deprecated methods
    • 23d2f5e6 - Restored setProperties method for backward compatibility
    • 7cb69247 - Use new OptionsSvc in GaudiPython
    • ac7f0b6d - Removed asymmetry Property<string> wrt Property<T>
    • a3d944f5 - Add Doxygen comments.

    Compare with previous version

  • Edited by Software for LHCb
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading