Skip to content

RD developments towards August 2024 MD

Miguel Ramos Pernas requested to merge rd-devel into 2024-patches

Dependencies

Depends on lhcb-datapkg/ParamFiles!100 (merged) (tunings of the MVA algorithms)

Overall impact on the bandwidth

image

Results obtained with 1cbbcaee, which was run in here

Goals

Include modifications for the period after the MD happening in August. The internal deadline is set to the 17th of July. Follows !3394 (merged). These changes include tweaks to lines, bug fixes and the inclusion of downstream and upstream reconstruction in different (new) lines.

Contributing

If you want to contribute to this MR, please speak first to @mramospe and @matzeni and explain your goals. We should avoid having clashes across different files, so if your line is defined in a module where other lines live, please coordinate among the contributors to the file to avoid conflicts. Once you are given green light to do changes, please do so and include in the description of this MR a little summary indicating the file(s) that you have modified as well as the changes to the lines. If you are changing a lot of different lines, please consider making a MR targeting the rd-devel branch. Note that we will not be able to run the central tests on that MR, but it will facilitate the review and the testing locally.

Any contributions to this MR should be ready by the 17th of July, in such a way that the impact on the rate, bandwidth and throughput has been studied and is within the thresholds.

The tests must be run using this snippet.

All the additions need to be tested locally, including:

  • Impact on the bandwidth and rate: if including new lines, these must be well justified (i.e. the physics case must not be already covered by other existing lines) and have rates and bandwidths below 100 Hz and 10 MB/s, respectively. This must be tested on real data. Follow the instructions at the RD migration meeting for advice on how to proceed. If you are tweaking existing lines the same thresholds apply.
  • Impact on the throughput: comparing the time with the execution of 2024-patches with no extra modifications.
  • (optional) Determine efficiencies: if there is simulation already available, it will be interesting to know the efficiencies so we ensure that there is no bug in the selections.

Do not rebase or force-push to this branch without the consent of @mramospe and/or @matzeni, since this might lead to losses on the changes

Handling Git conflicts

Since the rd-devel branch is based on 2024-patches, and due to the continuous development state of the latter, we need to do frequent rebase operations to keep it up-to-date. If you are collaborating in an independent branch e.g. username-devel you will need to have as a base rd-devel. You can do so via

git checkout rd-devel
git checkout -b username-devel

Note that if you have been initially basing the branch on 2024-patches at the point of changing the target branch in your merge request you will have a lot of commits from 2024-patches that will be added to rd-devel, which is not desirable (it will just add noise to the set of changes and be a source of potential conflicts). Something similar might happen if we rebase rd-devel; the base commit of username-devel will be lost because the whole history is reorganized during this operation (i.e. the base commit identifier, the hash, will no longer be in the history of rd-devel). In any of these two cases, we recommend to backup your branch with a new name (just in case) and then make use of the --onto argument of git rebase, like:

git branch -c username-devel username-devel-backup
git rebase --onto rd-devel rd-devel@{1} username-devel

This will put your branch username-devel so it is based on the last commit from rd-devel.

Changes

Please follow the same format as in !3394 (merged).

Global

  • Add CALO clusters and digits to lines with electrons, photons or neutral pions !3665 (merged)
  • Add make_down_electrons_with_brem in standard_particles.py !3660 (merged)

b_to_xll_hlt2_mva.py @mramospe

  • Changes to the monitoring of the MVA lines so the histograms end-up in the directory of the line instead of in an independent one

b_to_xll_hlt2_mva.py @acampove

b_to_xll_hlt2.py @rmwillia

  • Loosen B mass window for electron so m(B) > 3500 MeV.
  • To keep rates < or ~ 100 Hz apply cuts: PT(B) > 500 MeV & PT(e) > 500 MeV.
  • Add persist CALO information !3665 (merged)
  • Fix pi0 builder !3658 (merged)

strange.py @mramospe

  • Add the monitoring of the invariant mass to Sigma+ modes with neutral pions

  • Include CALO clusters and digits in strange lines requesting CALO raw banks

    !3660 (merged) @daproven :

  • new lines for K+, Lambda0 and Sigma+ using downstream tracks

  • new lines (Hlt2RD_KpToPiMuMuEE and Hlt2RD_KpToPiMuMuEE_Downstream)

  • IP for K+ semileptonic decays deleted (in Hlt2RD_KpToPiPiMuNu and Hlt2RD_KpToPiPiENu)

  • new Sigma+ lines with long protons and other downstream particles in the final-state (e.g. Hlt2RD_SigmaPlusToPMuMu_Long_Down)

  • new Xi- lines (Hlt2RD_XiMinusToAntiLambdaPi_...)

  • change Hlt2RD_SigmaPlusToPPi0_... lines from signal to control

strange_builders.py @daproven

  • Add new builders make_(loose/tight)_downstream_electrons, make_(loose/tight)_downstream_muons(for_sigma), make_(loose/tight)_downstream_protons_for_sigma , build_loose_downstream_dielectron_intermediate_neutral !3660 (merged)

rare_tau_decay_lines @cacochat

  • Enable also upstream electrons for the dielectron maker in the 2 tau_to_mugamma lines. !3468 (merged)

rare_tau_decay_lines @sicapell

  • Add parent_and_children isolation to TauToMuMuMu
  • Add parent_and_children isolation to DsToPhiPi_PhiToMuMu
  • Add new builder that combines two muons to create phi(1020)
  • Replace make_rd_detached_dimuons with _make_phi_to_2mu for phi in DsToPhiPi_PhiToMuMu
  • Use RD_MONITORING_VARIABLES in DsToPhiPi_PhiToMuMu

b_to_hemu_control_modes.py @rquaglia

  • Fix decay descriptor and document variations of decay descriptors
  • persistreco=True for flavour tagging in the channels Hlt2RD_BuToKpJpsi_JpsiToMuMu, Hlt2RD_BdToKstJpsi_KstToKpPim_JpsiToMuMu and Hlt2RD_BsToPhiJpsi_PhiToKK_JpsiToMuMu.
b_to_x_gamma @isanders
  • add isolation particles to PhiGamma and KstGamma lines !2669 (merged)
Edited by Miguel Ramos Pernas

Merge request reports