JetAccessories: avoid cloning and double ownership (and thus double delete) of Particles

• address this bug: f9a17847 (comment 7784341)
• use Particle::Selection instead of Particle::Container where appropriate to avoid cloning Particles
• avoid cloning of Particles in makeFastJets
• use Particle::Range instead of Particle::Container const& where appropriate
• use 'lazy' (on demand) range to obtain 'basic' particles from a composite

added bug fix cleanup labels

requested review from @rangel

assigned to @rangel

added 1 commit

• add61cce - Avoid cloning and double ownership (and thus double delete) of Particles

Compare with previous version

Does the old code cause segfaults in normal running?

added RTA label

added 1 commit

• d4f09a88 - Avoid cloning and double ownership (and thus double delete) of Particles

Compare with previous version

added 1 commit

• a8f2f48f - Avoid cloning and double ownership (and thus double delete) of Particles

Compare with previous version

added 1 commit

• a1944e54 - Avoid cloning and double ownership (and thus double delete) of Particles

Compare with previous version

added 1 commit

• c12999fb - Avoid cloning and double ownership (and thus double delete) of Particles

Compare with previous version

added 1 commit

• 8a8fbff1 - Avoid cloning and double ownership (and thus double delete) of Particles

Compare with previous version

added 1 commit

• b1741507 - Avoid cloning and double ownership (and thus double delete) of Particles

Compare with previous version

added 1 commit

• af5c9bae - Avoid cloning and double ownership (and thus double delete) of Particles

Compare with previous version

added 1 commit

• 4db37bab - Avoid cloning and double ownership (and thus double delete) of Particles

Compare with previous version

added 1 commit

• a76847a6 - Avoid cloning and double ownership (and thus double delete) of Particles

Compare with previous version

added 1 commit

• c94c284d - Avoid cloning and double ownership (and thus double delete) of Particles

Compare with previous version

added 1 commit

• 37861285 - Avoid cloning and double ownership (and thus double delete) of Particles

Compare with previous version

added 1 commit

• d2a0749b - Avoid cloning and double ownership (and thus double delete) of Particles

Compare with previous version

changed title from Avoid cloning and double ownership (and thus double delete) of Particles to JetAccessories: avoid cloning and double ownership (and thus double delete) of Particles

changed the description

mentioned in issue #544

added 1 commit

• 28e7d970 - Avoid cloning and double ownership (and thus double delete) of Particles

Compare with previous version

changed the description

assigned to @anfeng

unassigned @rangel

resolved all threads

/ci-test

added ci-test-triggered label

• [2024-03-28 22:33] Validation started with lhcb-master-mr#11290
• [2024-03-29 13:40] Validation started with lhcb-master-mr#11299
• [2024-03-29 20:09] Validation started with lhcb-master-mr#11305
• [2024-03-30 11:00] Validation started with lhcb-master-mr#11307
• [2024-03-31 12:10] Validation started with lhcb-master-mr#11311
• [2024-03-31 18:23] Validation started with lhcb-master-mr#11312
• [2024-04-03 12:19] Validation started with lhcb-master-mr#11342
• [2024-04-17 12:15] Validation started with lhcb-2024-patches-mr#128
• [2024-04-20 21:22] Validation started with lhcb-2024-patches-mr#164
• [2024-04-23 12:07] Validation started with lhcb-2024-patches-mr#185
• [2024-04-23 12:14] Validation started with lhcb-2024-patches-mr#186

added 2 commits

• ea42e936 - Avoid cloning and double ownership (and thus double delete) of Particles
• 217884d7 - implament `getBasic` seperately for C++17 and C++20

Compare with previous version

added 1 commit

• fef93ca0 - implement `getBasic` seperately for C++17 and C++20

Compare with previous version

added 1 commit

• e8c84924 - implement `getBasic` seperately for C++17 and C++20

Compare with previous version

added 1 commit

• 4a66cb30 - implement `getBasic` seperately for C++17 and C++20

Compare with previous version

added 10 commits

• 4a66cb30...e896e0fd - 8 commits from branch master
• 489b9d00 - Avoid cloning and double ownership (and thus double delete) of Particles
• 9bbba642 - implement `getBasic` seperately for C++17 and C++20

Compare with previous version

added 1 commit

• fc3c9fd3 - implement `getBasic` seperately for C++17 and C++20

Compare with previous version

added 1 commit

• 59b58cfd - implement `getBasic` seperately for C++17 and C++20

Compare with previous version

added 1 commit

• b6690c23 - implement `getBasic` seperately for C++17 and C++20

Compare with previous version

added 2 commits

• 9230ce62 - Avoid cloning and double ownership (and thus double delete) of Particles
• 938ad980 - implement `getBasic` seperately for C++17 and C++20

Compare with previous version

changed the description

added 1 commit

• 3836f6c0 - implement `getBasic` seperately for C++17 and C++20

Compare with previous version

added 1 commit

• 3b1ae7e5 - implement `getBasic` seperately for C++17 and C++20

Compare with previous version

added 1 commit

• 5ec6bceb - implement `getBasic` seperately for C++17 and C++20

Compare with previous version

added 1 commit

• 5a28a5f2 - implement `getBasic` seperately for C++17 and C++20

Compare with previous version

resolved all threads

added 1 commit

• d1e1abe9 - implement `getBasic` seperately for C++17 and C++20

Compare with previous version

added 1 commit

• 1d588d24 - implement `getBasic` seperately for C++17 and C++20

Compare with previous version

added 1 commit

• 08438ef1 - implement `getBasic` seperately for C++17 and C++20

Compare with previous version

added 1 commit

• ad1858ea - implement `getBasic` seperately for C++17 and C++20

Compare with previous version

added 1 commit

• ba581c50 - implement `getBasic` seperately for C++17 and C++20

Compare with previous version

resolved all threads

requested review from @helder

mentioned in issue Moore#730 (closed)

resolved all threads

mentioned in issue #545

assigned to @oozcelik and unassigned @anfeng

added 7 commits

• ba581c50...f0cbea82 - 4 commits from branch master
• e8b5a9d3 - Avoid cloning and double ownership (and thus double delete) of Particles
• ea59283f - implement `getBasic` seperately for C++17 and C++20
• e7eef1ec - Further cleanup of Jet code:

Compare with previous version

added 1 commit

• 0debe131 - Further cleanup of Jet code:

Compare with previous version

mentioned in issue Moore#718

mentioned in issue #547

added 1 deleted label

changed target branch from master to 2024-patches

resolved all threads

@helder, @rangel: please either review, or explicitly state you are not available to do so, and if so, please suggest alternates.

added 21 commits

• 0debe131...5d562c23 - 16 commits from branch 2024-patches
• 538ad395 - Added UT Hit dumper for event display
• 67d9b555 - Merge branch 'sponce_UTHitDumper' into 'master'
• c1adc038 - Avoid cloning and double ownership (and thus double delete) of Particles
• be7a710c - implement `getBasic` seperately for C++17 and C++20
• 7f67bc9b - Further cleanup of Jet code:

Compare with previous version

approved this merge request

Hi. Sorry for not responding, I've been very busy these days. Thanks @dfitzger for looking at this. I'm just compiling a new stack to also have a look at these changes.

assigned to @isanders

added Jets label

Hello! I've being testing this new code and it's OK for me. In fact it fixes a bug in ParticleFlowMakerMC that in some cases used both a particle and one of its daughter in the particle flow. Thanks Gerhard.

approved this merge request

/ci-test

assigned to @cagapopo and unassigned @oozcelik

@graven just noticed this one, https://gitlab.cern.ch/lhcb/Rec/-/blob/master/Phys/ParticleCombiners/src/ParticleContainerMerger.cpp, still copies the Particle instead of making a Particle::Selection. Maybe we can address that here too? Or was there a reason to keep this that way?

mentioned in merge request !3881 (merged)

assigned to @jonrob and unassigned @cagapopo

added 27 commits

• 7f67bc9b...5508cbfd - 23 commits from branch 2024-patches
• a309e2b0 - Added UT Hit dumper for event display
• 2b73dc6b - Avoid cloning and double ownership (and thus double delete) of Particles
• af8de738 - implement `getBasic` seperately for C++17 and C++20
• e0688662 - Further cleanup of Jet code:

Compare with previous version

/ci-test !3881 (merged)

resolved all threads

mentioned in commit 09153404

merged

mentioned in merge request !3889 (merged)

mentioned in issue Moore#767 (closed)