William Axel Leight authored 5 years ago and Vakhtang Tsulaia committed 5 years ago

Apologies for blending three fixes into a single MR, but each involve small changes to a single file:

1. CSC and NSW hits are only written out now if the corresponding detectors are actually used
2. The MuonCombinedInDetExtensionAlg was using obsolete names for the NSW PRD containers
3. The sorting of calo and MS hits in the SortTSOSs method was exactly backwards.

TrigCaloRec: Avoid EventContext TLS lookups.

See merge request atlas/athena!23389

Fix thinning of HLTResult (ATR-18627)

See merge request atlas/athena!23373

Make methods of SiSpacePointsSeedMaker_ITK const by defining EventData to hold event dependent data.

See merge request atlas/athena!23351

Susumu Oda authored 5 years ago and Vakhtang Tsulaia committed 5 years ago

Make methods of SiSpacePointsSeedMaker_ITK const by defining EventData to hold event dependent data.

Make methods of SiSpacePointsSeedMaker_LowMomentum const by defining EventData to hold event dependent data.

See merge request atlas/athena!23349

Susumu Oda authored 5 years ago and Vakhtang Tsulaia committed 5 years ago

Make methods of SiSpacePointsSeedMaker_LowMomentum const by defining EventData to hold event dependent data.

Add new empty menu test running on data

See merge request atlas/athena!23371

TrackToCalo+MuonCombinedBaseTools: Migrate from CaloNoiseTool to CaloNoise conditions object.

See merge request atlas/athena!23358

Scott Snyder authored 5 years ago and Vakhtang Tsulaia committed 5 years ago

Migrate CaloCellCollector from CaloNoiseTool to CaloNoise conditions object.
Remove a bad const_cast in passing.

AthenaKernel: A couple comment fixes.

See merge request atlas/athena!23382

InDetZVTOPVxFinder: const fixes

See merge request atlas/athena!23383

TrigMuonMatching: Declare most TrigMuonMatching methods as const.

See merge request atlas/athena!23384

DerivationFrameworkMuons: Make methods of MuonTPExtrapolationTool const.

See merge request atlas/athena!23386

TrkTrackCollectionMerger: ToolHandle constness fix.

See merge request atlas/athena!23387

TrigT2CaloEgamma: Avoid EventContext TLS lookups.

See merge request atlas/athena!23390

Use DeclareInterfaceID and extends for (I)SeedToTrackConversionTool

See merge request atlas/athena!23396

Use DeclareInterfaceID and extends for (I)SiDetElementsRoadMaker(_xk)

See merge request atlas/athena!23397

Use DeclareInterfaceID and extends for (I)SiCombinatorialTrackFinder(_xk)

See merge request atlas/athena!23398

Use DeclareInterfaceID and extends for (I)SiTrackMaker(_xk)

See merge request atlas/athena!23399

Use DeclareInterfaceID and extends for (I)SiZvertexMaker(_xk)

See merge request atlas/athena!23400

Code cleanup of SiClusterizationTool package

See merge request atlas/athena!23401

Don't fetch EventContext from thread-local storage if we already have
it as an argument.

Don't fetch EventContext from thread-local storage if we already have
it as an argument.

Make mergeTrack() non-const, to avoid calling a non-const method through
a const ToolHandle.

Make most methods of MuonTPExtrapolationTool const.
Needed to fix non-const calls through const ToolHandles.

Declare most methods of TrigMuonMatching as const.
Needed to fix non-const method calls through a const ToolHandle
in DerivationFrameworkMuons.

The matchDimuon methods are still non-const, as they manipulate
an internal cache.

Add a bunch of const qualifiers to methods.
Needed to fix non-const calls through const ToolHandles.
(Still have issues with calls to IVertexFitter::fit.)

Add ATLAS_CHECK_THREAD_SAFETY to InDetTrackScoringTools package

See merge request atlas/athena!23365

Add ATLAS_CHECK_THREAD_SAFETY to SiZvertexTool_xk

See merge request atlas/athena!23356

Code cleanup of TrkAmbiguitySolver

See merge request atlas/athena!23364