Closes ATEAM-677

This reverts merge request !38137

Rafal Bielski authored 4 years ago and Frank Winklmeier committed 4 years ago

```
HltEventLoopMgr.cxx:549:66: warning: Method called on moved-from object 'eventContextPtr' [clang-analyzer-cplusplus.Move]
HltEventLoopMgr.cxx:750:45: warning: Method called on moved-from object 'ctx' [clang-analyzer-cplusplus.Move]
```

Krzysztof Marian Korcyl authored 4 years ago and Frank Winklmeier committed 4 years ago

fixing 38564 MR threads + removing commented out lines + removing AthenaST-style root booking and filling code

Aleksandra Poreba authored 4 years ago and Adam Edward Barton committed 4 years ago

- add algIdx to rosIdx caching
- set cost and ros collection at once

With Gaudi v34r1 (!37533), handle properties changed from type `str` to
`DataHandle`. Explicit `str` conversion is required for extracting the
key name.

Closes ATR-22396.

`PYTHONSETUPFILE` is not available when running in a partition. Suppress
the warning message.

Avoid spurious object copy in range for.

Disable the auto-retrieval of tools introduced in
gaudi/Gaudi!1124 as this is not relevant for the EventLoopMgr.

This code was used during Run-1 to store HLT rates in COOL.

Due to thread-safety changes in ByteStreamCnvSvc, there is no longer
a m_rawEventWrite member.  Use the interfaces from the base class instead.

Mark Stockton authored 4 years ago and Walter Lampl committed 4 years ago

Requires update Cost workflow for Trig_reco_tf (ATR-20974)
- Define COST BS output as DRAW_TRIGCOST (rather than a second BS to avoid conflicts in ProdSys)
- Split full BS to fill CostMon stream into the DRAW (before splitting other streams as requested)

- DRAW_TRIGCOST needs registering before can be used in ProdSys
- athena arguments for RAWtoCOST updated, but need further changes when scripts are ready

 - Pass class instances by const reference, not by value.
 - assert() with side effects.
 - unused value.
 

Thread-safety annotations should match between declarations and definitions.

Joerg Stelzer authored 4 years ago and Vakhtang Tsulaia committed 4 years ago

When running from the DB in athenaHLT, the HLTPSK needs to be read from
the database directly, `HLTPrescaleCondAlg.Source` needs to be changed
to `DB` to avoid trying to read the key from COOL.

Relates to ATR-22143.

- try to release early possible locks in tbb::concurrent_unordered_map (see also ATR-22112)
- put clearing and size allocation for output arrays of the eventCache_checkRobListToCache function
  at the begin of the function

Always put ROOT into batch mode to avoid additional GUI threads being
created that could cause problems during forking (ATR-21890).

!36223 introduced a slight change in behavior when reading
`DF_Enabled_ROB_IDs`, i.e. it was always overwriting the list of enabled
ROBs even if a value was set explicitly via job options.

Fix bug when parsing job properties of the type `MyAlg.MyTool.MyProp`.
The client name is in this case `MyAlg.MyTool` and not only `MyAlg`.