Nils Erik Krumnack authored 4 years ago and Atlas Nightlybuild committed 4 years ago

AnalysisTop bugfix for extraSmearing option for muons

See merge request atlas/athena!37621

(cherry picked from commit aee230fc2f9b375b5ef156b2ccffa8aa63038ea6)

14c37eda bugfix for AT implementation of muon doExtraSmearing
8bda2d38 second part of the fix

Christos Anastopoulos authored 4 years ago and Edward Moyse committed 4 years ago

CaloROI selector, InDet and GSF . Python fixes . Also add Minimal sanity Reta . Should have ~0 effect for true electrons , could alter a bit the fakes we have

- remove `atlas_depends_on_subdirs`
- remove unused CLHEP dependency and cleanup includes
- enable flake8 and fix code

Hello,

This MR adds the functionality to thin the CaloCalTopoClusters_links container and only keep the entries associated with tau clusters.
This container is needed for the tau cluster-to-cell navigation in xAODs, but it too large to be written out without thinning.
As discussed in ATLTAU-1733, the CaloClusterCellLinkContainer thinning was not supported so far, and Scott just implemented it (not merged yet).
Once it's in Athena, the CaloCalTopoClusters_links size should be reduced significantly (I'm already adding the container to the xAOD output to minimise the number of MRs, so we expect a jump in xAOD size, ATLASRECTS-5684).
According to q221 run on 40 events, thinning reduces the container size by a factor of 2.5 (3.0 kb/evt after thinning).

Cheers,
Bertrand

The cmake configuration for these packages is empty, so clearly this
code is not being used. Also there are no significant changes since many
years.

Xiaozhong Huang authored 4 years ago and Frank Winklmeier committed 4 years ago

The constituent p4 is buggy for EMPFlow seed jets, but the p4 of the
rawConstituent is OK. As a workaround, we now use the rawConstituent
p4.

That argument controls whether LArge Radius Tracks have CaloExtensions created.

Bertrand Martin Dit Latour authored 4 years ago and Frank Winklmeier committed 4 years ago

Hello,

This MR is introducing a flag to skip tau candidates that have too many tau tracks.
The number of tracks corresponds to the number of tracks classified as good tau tracks by the tau track classifier.
Currently, we already run part of the tau reconstruction (tau substructure reconstruction) for candidates that have 1-5 tracks.
The new flag can be used to run the whole reconstruction only for taus with e.g. 0-5 tracks.
We would save some CPU and disk (relevant ticket: ATLASRECTS-5684).
The main motivation is that taus with >3 tracks will never be used in analyses.
0-track candidates should be kept as they are good candidates for e.g. neutral LLP->tau. The 1-3 track candidates are for physics. Keeping up to e.g. 5-track candidates gives some flexibility to retune and improve the track classifier at xAOD level, although that is somewhat unlikely to happen.

Cheers,
Bertrand

Ricardo Barrue authored 4 years ago and Frank Winklmeier committed 4 years ago

Filling histograms of the matching variable for all jets and filling the ptdiff histogram for all the jets that are matched

Previously, we use the jet vertex corrected four momentum to select the
consistuents to calculate tau axis even when the tau vertex is different
with the jet axis. To be consistent, we now use the tau vertex corrected
four momentum if we do the tau vertex correction.

Hello,

This MR is hopefully the last in the tau pi0 MR series :-)
Following the recent reorganisation of our pi0 containers, we are dropping a container that is no longer used.
We are now left with only 2 pi0 containers in the tau reconstruction: TauInitialPi0Clusters (transient, which results from the topoclustering of cells from the TauCommonPi0Cells container), and TauPi0Clusters (persistent, which are identical except that their cells point to the AllCalo container).
This MR does not change the reconstruction output.

Cheers,
Bertrand

Bug fix such that for LRT version of CaloExtensionBuilderAlg we change the calo extension cache name.

Updating the iPatSLFitter configuartion to use the right name so that it doesn't overwrite the default (non-straight line) version of the iPatFitter configuration.

A type meant no preExec was actually used, resulting in ATR-22074

Liaoshan Shi authored 4 years ago and Frank Winklmeier committed 4 years ago

Previous value was set to the total  total number
of samplers that all monitors of the same type have to connect.
New value is the number of samplers per monitoring task.

Nils Erik Krumnack authored 4 years ago and Atlas Nightlybuild committed 4 years ago

Add default move constructor for HbbTag

See merge request atlas/athena!37573

(cherry picked from commit ac36430b189bc7444f0a0095446706a102dbf98c)

64cbdf5f Add default move constructor