- remove the pixel covariance correction,
- remove dRmap based identification of collimated tracks,
- remove creation of dRmap.

All of the above is unused and was not properly migrated to athenaMT.

Robin Newhouse authored 4 years ago and Frank Winklmeier committed 4 years ago

Other changes include:
snake_case -> camelCase
stl math functions
Removing NN configuration from new tracking cuts
A temporary override of config filepath for testing purposes. Will be removed before final merge.

Add configurable flag ofr CaloClusterEt for ROiSeed in NewTrackingCuts and changing default cutlevel to 19

Maximilian Emanuel Goblirsch-Kolb authored 4 years ago and Frank Winklmeier committed 4 years ago

Revert "Merge remote-tracking branch 'upstream-nora/npetters-addmaterialcorrection-SiComTrackFinder' into master-tuneTrackFinder"

This reverts commit c21761a1b8ad4b1e2ac52bc1c4352dbec60f048e, reversing
changes made to 82e276a21ceedea302ca1ba3a8649c2fd4938348.

If the flag is set the TRT error scaling will use mu from either
the offline or online luminosity conditions data.

Further fixes for python 3.

This reverts merge request !30166

This reverts merge request !30116

print function.

Stewart Martin-Haugh authored 5 years ago and Vakhtang Tsulaia committed 5 years ago

This reverts commit 39bcc170d9cdb5e46ee3350de82607faf3272297.

TRT_Phase data is not produced during collisions, but monitoring was
trying to read it.  Disabled.  Previously this wasn't noticed, but the
TRT_Phase access was recently changed to use a handle, and it is
now giving errors in the debug build.

Sofia Adorni Braccesi Chiassi authored 6 years ago and Edward Moyse committed 6 years ago

Changes in the ambiguity solver to improve tracking for high Pt Bs. Changes can be turned on by using two different flags.


Former-commit-id: 363b497d

Change HI config (temporarily, while longer term solution is in progress) to address ATLASRECTS-4691


Former-commit-id: fcd913c4

Add flag to toggle use of digital ROT creation (and include other changes from egamma fix in 21.0). Using this will save some CPU, but currently does not give optimal egamma performance - see ATLASRECTS-3949, ATLASRECTS-4573.

Set false by default for egamma tuning until GXF changes can be made to fully support use of PRDs properly.

Update

update


Former-commit-id: bec720ed

Former-commit-id: 66952102

master (sweep failed). Since the original request there were changes
in the SCT and TRT alignment code thus the CP is not exactly
equivalent to !7888 but tries to merge these developments.


Former-commit-id: 2302505c

Former-commit-id: 5daee2ed

avoid the need of the conversion from the new scheme to the old.

The scheme used is controlled by
InDetGMProperties.useDynamicAlignFolders setting. This replaces the
old setting of the same name in InDetFlags/InDetTrigFlags and the need
of modifying the offline IndetFlags setting in the online job. It
allows also to simplify InDetAlignFolders and avoid dependency of this
package on the reconstruction. This is related to the discussion in ATLASSIM-2746 and ATR-13872

Further changes are to propagate the setting from *DetectorTool
properties to the actual geomodel DetectorFactories where different
sets of folders are accessed. It allows to deprecate the method
getAlignFolderType which did guessing of the alignment scheme based on
the presence of the folders and which is not robust in the case 2 sets
of folders are present in the db. It also reduces the amount of
WARNINGs produced (ATLASRECTS-3800) and makes them more meaningful.

I'm happy to iterate on the implementation especially because I did
not test but the online usecase (with a combination of the online
database and an sqlite file with the new folders) and for example more
clients of the old InDetFlags setting may need adjustment. The request
is for the moment for the online 21.1 release and I'm marking it
urgent to be able to validate it in a release before the first stable beams.


Former-commit-id: 4c71bfb3

Former-commit-id: 488222c7

James Beacham authored 7 years ago and Atlas Nightlybuild committed 7 years ago

Add new cut level 15 with tighter hit requirements (7->8 Si clusters) for testing

See merge request atlas/athena!8197

(cherry picked from commit 9cf0e2db [formerly c137cc9dacd5def671ead8a38b5eb937dd09a0dd])

fc7cb6d3 Add new cut level 15 with tighter hit requirements (7->8 Si clusters) for…

Former-commit-id: 55f8b53a

Tamara Vazquez Schroeder authored 7 years ago and Atlas Nightlybuild committed 7 years ago

Introduce new InDet option doLowPtLargeD0 (ATLMCPROD-4720)

See merge request !4272

Former-commit-id: 5f9693a6

Hass AbouZeid authored 7 years ago and Atlas Nightlybuild committed 7 years ago

Check dead elements on track by default.

See merge request !3606

Former-commit-id: d466d69e

- Removed algorithms
- Updated configuration to reflect the removal of obsolete n-tuple writer.
- Removed documentation about removed ntuple writer.
- Removed flags doTrtDriftCircleNtuple and doPixelClusterNtuple.


Former-commit-id: 6527f1f5

Hass AbouZeid authored 7 years ago and Atlas Nightlybuild committed 7 years ago

AOD reductions for release 21 - ID track pT cut

See merge request !1040

Former-commit-id: 0338615a