Benjamin Philip Kerridge authored 4 years ago and Walter Lampl committed 4 years ago

FTF Config migration to ConfigSettings. Began to use ConfigSettings in place of InDetTrigSliceSettings

Build only tracks with npix+nsct >= 10

The RegSelTestAlg, TRTRawDataProvider and the RoIPEBInfoWriterTool were still accessing
the old RegSelSvc, the TRTRawDataPRovider was just overlooked, whereas the other two were
looping over the RegSelEnum to call the RegSelSvc on all the systems.

These have been fixed now.

Mark Sutton authored 4 years ago and Walter Lampl committed 4 years ago

Add a full scan test, add additional panels to the plotting, fix the incorrect selection of histograms

An extra validation test running the fullscan tests is added - running from a jet chain, rather than
a bjet chain (will need a jet performance test at some point)

In addition, it adds extra panels for the plotting showing the hit multiplicities and the raw distributions.

Finally, a fix to the configuration of the histogram selection in the FTF monitoring has been added.

Switching builder classes to free functions, getters are now for fetching tools from RecLoadTools config, adding new slice settings (mainly track collections), making recordable as decorator, removing remap from FTF and adding it to slice settings

Also add some protection for all the potential fullscan instances of the
histogram parameters

Stewart Martin-Haugh authored 4 years ago and Adam Edward Barton committed 4 years ago

TrigmuComb: Migrate from magnetic field service to CondAlg (ATR-21737)

See merge request atlas/athena!34872

revised version of the HLT InDet GPU demonstrator for AthenaMT, resolves the issues identified in !33485

Mark Sutton authored 4 years ago and Adam Edward Barton committed 4 years ago

There were inconsistencies in the way the ID Trigger sequences were configured.
These changes partly address thie to tidy the configuration code somewhat.
As part of this is a fix to the naming convention in the beamspot chains, together
with the implementation of a test beamspot chain in the LS2 menu. This includes a
renaming of the beamspot chain in the pp_run3 menu, to conform to the established
naming conventin from Run 2, that has been agreed with Menu coordination.

Matous Vozak authored 4 years ago and Frank Winklmeier committed 4 years ago

Adding cosmic configuration, Trigger keys, new ID trig track monitoring, ID trig common macros, EFID tracking

The `labels` argument in `defineHistogram` is deprecated
and replaced by `x/ylabels`.

Make `TrigFastTrackFinderMonitoring` compatible with GaudiConfig2 where
`self.name` is not directly writable anymore.

Stewart Martin-Haugh authored 5 years ago and Frank Winklmeier committed 5 years ago

Unused private data members.

Mark Sutton authored 5 years ago and Frank Winklmeier committed 5 years ago

These include several updates to the RegSelTool implementation with respect
to merge request !30981

Firstly better memory handling for the RegSelLUTCondData where the
payload is now stored using a unique_ptr to better avoid memory leaks.

Additionally there is an new class for the MDT_RegSelCondAlg which
uses the new MDT cabling conditions data to create the table for the
RegSelTool.

The RegSelToolConfig.py now has an improved private builder function,
whoch is used to provide public builders for the Pixel, SCT, TRT and MDT.

The SCT Cabling conditions data are now used for the EventIDRange for
the SCT table, rather than using the pixel cabling.

Some of the old RegSelSvc code has been retained, but commented since
we are still developing.

One additional factor regarding the MDT table creation code: The
createTable() method is essentially a cut and past of the original
MDT code from the MDT_RegionSelectorTable class. I did not originally
write this code, and don't want to touch it as that would require a
great deal of validation beyond the scope of the changes for this
merge request. There are a good many places where that code itself
could be improved, but that should be left for the Muon developers
for a later day.

For this code we are implementing the framework to provide the full
functionality for the new RegSelTool implementation so there will be
quite a lot of copying of code from the older implementation over
the coming weeks for the additional Muon and Calorimeter tables.

This includes all the fully functional changes for the new conditions data access
RegSelTool access to replace the egregious old RegSelSvc class

New classes are included:
```
   * RegSelCondData    a generic wrapper class for conditions data
   * RegSelLUTCondData the specific instance of the above wrapper for the RegSelSiLUT
                        conditions data for the ID And MS lookup tables
   * SiRegSelCondAlg    the new conditions algorithms to add the conditions data
```
Modifications are also included for the FastTrackFinder and the
TrigSpacePointConversionTool to replace the use of the RegSelSvc for the Pixel and
SCT in the SpacepointConversion tool by way of example - it is not a full replacement
in this package.

New configuration functions are provided in
```
	RegSelToolConfig.py
```
such that components can include the relevant RS tools using fragments such as
```
  from RegionSelector.RegSelToolConfig import makeRegSelTool
  spTool.RegSel_Pixel = makeRegSelTool("Pixel")
  spTool.RegSel_SCT   = makeRegSelTool("SCT")
```
The setup functions register the corresponding conditions algorithms when called
ensuring that they are registered once, and once only.

The code to use the RegSelSvc in this tool has been retained, but has been commented
out, since this change is still very much ongoing. The cleanup to remove this older
code will come along with the full replacement of the RegSelSvc in the full package
(and others) once the remaining RegSelTool developments are more complete.

Changes for the TRT and Muon Spectrometer region selector code will come once these
initial changes have been merged.

- implemented switch between run-2 and run-3 (ATR-20305)
- unified histo folder names (ATR-20305)
- fixed z-finder timer for non z-finder algos (ATR-20305)
- timer monitor change to milliseconds (ATR-20883)

Setting up the late muon trigger to run on out of time RoIs (produced by TrigmuRoI). Also configuring the data decoding and ID tracking to run in these RoIs (this required some modification on the decoding configuration, and a new instnce of the fast track finder).
The chain now runs in a full scan RoI mode, then creates the out of time RoIs then runs the data decoding, ID tarcking, and late muon reconstruction in one step (ATR-17553).

Susumu Oda authored 5 years ago and Adam Edward Barton committed 5 years ago

Add ATLAS_CHECK_THREAD_SAFETY. Add ATLAS_THREAD_SAFE to m_cache and m_layerVectors[3]. Change file mode to 644.

Savanna Shaw authored 5 years ago and Adam Edward Barton committed 5 years ago

Includes proper configuration of EF muon isolation algorithm and hypo,
setup of proper sequence to run ID tracking around muons and calculate the
isoltion, and addition of the relevant pieces to the menu.