PanTau code cleanup

See merge request atlas/athena!38383

TrkAlignGenTools+ForwardRegion_EventTPCnv: cmake fix

See merge request atlas/athena!38408

Fix checks for preexisting inputs to jet finding

See merge request atlas/athena!38397

ParametersBase . Add direct setters , fix  TrackParticleAthenaPool test

See merge request atlas/athena!38399

Fix typos in two diff test scripts.

See merge request atlas/athena!38379

Switch to new DQ monitoring by default

See merge request atlas/athena!38398

dqm_algorithms: Fix compilation with clang.

See merge request atlas/athena!38400

LArRawEvent+ISF_FastCaloSimParametrization: Fix cppcheck warnings.

See merge request atlas/athena!38401

TrkGeometry Layers: Remove unneeded virtual methods/ mark methods as final.

See merge request atlas/athena!38410

IPropagator/IExtrapolator remove virtual from methods that do not need to be virtual

See merge request atlas/athena!38407

LArMonitoring: cmake fixes

See merge request atlas/athena!38406

InDetPhysValMonitoring: Increase test timeout.

See merge request atlas/athena!38402

TrkGeometry Layers: Remove unneeded virtual methods.Also mark methods as final where applicable/possible

Remove unneeded / undefined EIGEN_INCLUDE_DIRS.

Remove unused / unneeded ROOT_INCLUDE_DIRS.

Don't build an object into more than one library.

Fix timeout observed running test.

 - Prefer preincrement to postincrement for user iterators.

 - Prefer to pass large objects by const reference instead of by value.
 - Avoid post-increment of user iterators.

The template definitions for LastBinThresholdAction are only in the cxx file.
So need to ensure within that file that instantations of that template
are complete.

Try to plug memory leaks in TRT_BaseElement ATLASRECTS-5271

See merge request atlas/athena!38322

Update packages:TauAnalysisTools  from upstream/21.2 to upstream/master via pseudo-merge (ATLTAU-1727)

See merge request atlas/athena!38284

Guillermo Nicolas Hamity authored 4 years ago and Adam Edward Barton committed 4 years ago

Fixing member variable ATLAS standard warning.

modify filtering for L2 inside-out

See merge request atlas/athena!38374

Sweeping !38095 from 21.0 to master.
New TFCSEnergyInterpolationPiecewiseLinear class for piecewise linear interpolation

See merge request atlas/athena!38367

HepMC3 Fix, master branch (2020.11.17.)

See merge request atlas/athena!38331

Use /SCT/DAQ/Config/ChipSlim for Run 2 and 3 data (CONDBR2 instance) (ATLASRECTS-2851)

See merge request atlas/athena!38319

ISF art test and Transform integration

See merge request atlas/athena!38344

Hello,

This MR is cleaning up the PanTau code, which is no longer maintained but still used in the tau reconstruction.
This is just to improve code readability for a possible rework or simplification of the code, which might be attemped before the reprocessing.
I also dropped a few calculations that are made internally but used nowhere.
This MR does not change the reconstruction output.

Cheers,
Bertrand

Increasing default large-R truth jet threshold

See merge request atlas/athena!38334

Remove ROBDataMonitor_type_traits_test

See merge request atlas/athena!38375

Remove position and momentum caching from pattern parameters

See merge request atlas/athena!38348

Stephen Nicholas Swatman authored 4 years ago and Adam Edward Barton committed 4 years ago

Currently, we're storing the charge value of the pattern track
parameters in a cached value, but this is not really necessary.
Computing the charge is so trivial and fast (from the q/p value) that
there really is no reason to cache this. We use the lazy binding
behaviour of the charge method to simply recompute on the fly.