Skip to content
Snippets Groups Projects
  1. Dec 20, 2018
    • Rafal Bielski's avatar
      Fix decision creating in MTCalibPebHypoAlg · ea3e5ebd
      Rafal Bielski authored
      It was broken by recent updates in TrigCompositeUtils. This commit updates the alg to the new TrigCompositeUtils interface.
      ea3e5ebd
    • Frank Winklmeier's avatar
      athenaHLT: Write histograms into their own directory when forking · 3d46017d
      Frank Winklmeier authored
      - Add the missing call to `updateDFProps` after the fork to
        individualize the child properties (e.g. app name).
      - Use the `IoComponentMgr` to mange the I/O for child processes as done in
        athenaMP. This creates a sub-directory for each child into which histogram
        files are being written.
      - With the above we can run also in `athenaHLT.py` using the offline
        `THistSvc`.
      
      TODO: It's not nice that we are creating empty directories in case the
      online `THistSvc` is used. Can probably add a check on the number of
      registered files and if zero, don't bother with the I/O component
      manager.
      3d46017d
  2. Dec 19, 2018
    • Frank Winklmeier's avatar
      TrigServices: delete hadd.[C,sh] · 93713a95
      Frank Winklmeier authored
      93713a95
    • Frank Winklmeier's avatar
      Configuration cleanup for athenaHLT · c3f88b26
      Frank Winklmeier authored
      - Move all configuration of athenaHLT services to TriggerUnixStandardSetup.py.
        Remove the use of includes as much as possible (apart from user job options).
      - Replace the OfflineTHistSvc.py include with a simple flag
      - Add error in case the offline THistSvc is used with more than one child
      - Move the configuration of HLTResultMTMaker to its own module
      c3f88b26
  3. Dec 18, 2018
  4. Dec 17, 2018
    • Walter Lampl's avatar
      Fix file permissions of identical files · d00fba15
      Walter Lampl authored
      Files with identical content (same SHA1) but different file permissions
      cause confusing differences shown in GitLab. The file permissions of
      61 files were set to 644 (ATLINFR-2011).
      d00fba15
  5. Dec 13, 2018
  6. Dec 06, 2018
  7. Dec 05, 2018
    • Frank Winklmeier's avatar
      athenaHLT: Fix setting of interactive mode · b2faa485
      Frank Winklmeier authored
      The PSC modifies its state machine if we are running in interactive mode
      (to allow debugging of the python configuration before initialize is
      called). Previously interactive mode was flagged by a global
      'interactive' variable. This is now done directly in athenaHLT.py.
      
      
      Former-commit-id: b7139344
      b2faa485
    • Frank Winklmeier's avatar
      TrigPSC: remove obsolete code · 0eca21b2
      Frank Winklmeier authored
      - Remove unnecessary `release()` calls (the ServiceHandle does this)
      - Remove commented code
      - Remove code to handle user commands as this is non-functional now
      - Remove dllName, factoryName and EvtSel properties (see HLTPUDal!1)
      
      
      Former-commit-id: 355f8d6756be798bc07a81a90d3e9755f269fc9c
      0eca21b2
  8. Nov 29, 2018
  9. Nov 28, 2018
  10. Nov 27, 2018
    • Rafal Bielski's avatar
      New HLTResultMT ByteStream decoder algorithm · 382c725c
      Rafal Bielski authored
      Changes include:
      * implement HLTResultMTByteStreamDecoderAlg and the corresponding tool -> this reentrant algorithm replaces the functionality of Gaudi Converter for BS decoding, since Converters are inherently not compatible with athenaMT
      * make the Converter method HLT::HLTResultMTByteStreamCnv::createObj fail when used with a message to use the Alg instead
      * allow TriggerEDMDeserialiserAlg to skip events with no payload - this is needed at least for testing our first bytestream files with new HLTResultMT
      * rename one of the HLTResultMT::setStatus overload to setErrorCodes because the overload was ambiguous (compilation error when used)
      * add the implementation of operator<<(std::ostream&, const HLT::HLTResultMT&) for useful debug printouts
      * add MTCalibPebDecisions to the list of serialised collections in MTCalibPeb.py in order to produce some payload
      * fix the payload writing in HLT::HLTResultMTByteStreamCnv::createRep (missing reference operator)
      
      
      Former-commit-id: e03390a9
      382c725c
  11. Nov 26, 2018
  12. Nov 23, 2018
  13. Nov 22, 2018
  14. Nov 21, 2018
  15. Nov 17, 2018
  16. Nov 16, 2018
    • Rafal Bielski's avatar
      Improvements in HLTResultMT · 39e223e0
      Rafal Bielski authored
      * Add some error handling in HLTResultMT introducing StatusCode and AthCheckMacros
      * HLTResultMT now removes duplicate stream tags also in setStreamTags - both setStreamTags and addStreamTag now return StatusCode
      * HLTResultMT::getSerialisedData now returns StatusCode and pointer to the data is passed in the argument - this ensures error handling in the case when the caller asks for data with a moduleId which is not in the stored map
      * new method HLTResultMT::addSerialisedDataWithCheck to add data only for modules which are not yet in the map - returns StatusCode::FAILURE if moduleId is already in the map; the no-check method void addSerialisedData simply appends new data if moduleId already exists
      * Ensure the status words in HLTResultMT consist of 1 bit-mask word (eformat::helper::Status) + optional error codes (used to store hltonl::PSCErrorCode). This is how the status field was used in Run 2, although the first word was built entirely on the TDAQ side in DCM. The agreement between HLT and TDAQ is to provide it in this form already from the HLT side in the new interface where we produce a FullEventFragment, then DCM can simply apply an OR bit mask to the first word without touching the rest, if it wants to add extra error flags.
      * HLT bits are now stored as boost::dynamic_bitset, which makes the bit operations less error prone, e.g. HLTResultMT::addHltBit is now well defined and easy to follow. For serialisation purpose, HLTResultMT still needs to own a vector<uint32_t> representation of the bits because the lifetime of this vector has to extend beyond the BS converter createRep method, namely until the end of conversion service's commitOutput. The vector representation does not have any setters and is updated only by the getter method.
      * Add more comments in HLTResultMT.h
      * Adapt TriggerBitsMakerTool, TriggerEDMSerialiserTool, TriggerEDMDeserialiserAlg, HLTResultMTByteStreamCnv, HltEventLoopMgr to the changes
      * Improve formatting of FullEventFragment header printout in TrigByteStreamCnvSvc
      
      
      Former-commit-id: 32678df6
      39e223e0
  17. Nov 14, 2018
  18. Nov 01, 2018
    • Frank Winklmeier's avatar
      Update packages:HLToks JiveXMLServer HLTUtils TrigTransform TrigCommon... · 23915202
      Frank Winklmeier authored
      Update packages:HLToks JiveXMLServer HLTUtils TrigTransform TrigCommon TrigExMTHelloWorldLvl1 TrigExPartialEB TrigExL2muCalibTest TrigExMTHelloWorld TrigServices TrigPython TrigKernel TrigPSC HLTRates2COOL TrigOnlineMonitor TrigConf2COOLOnline HLTTestApps ByteStreamEmonSvc TrigByteStreamCnvSvc  from upstream/21.1 to upstream/master via pseudo-merge
      
      
      Former-commit-id: 0fe4136b
      23915202
  19. Oct 30, 2018
Loading