Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • L LHCb
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 193
    • Issues 193
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 42
    • Merge requests 42
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • LHCb
  • Merge requests
  • !3789

Dropped compilation of DetDesc in DD4hep mode and adapted code

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Sebastien Ponce requested to merge sponce_ITransportSvcsimplification into master Sep 23, 2022
  • Overview 191
  • Commits 26
  • Pipelines 28
  • Changes 141

This includes :

  • a cleanup of the TransportSvc interface
    • dropped old non reentrant methods
    • renamed reentrant methods withour "_r"
    • return intersections in intersections methods, rather than relying on filling a vector passed by reference (and cleaning it first)
    • removed unused entry points
  • usage of dd4hep Material through the wrapper Detector::Material
    • provides the same interface as DetDesc
    • but is a Handle and not a pointer, hence a bunch of ifdefs in key places
  • dropping a lot of unused code/classes :
    • OfflineRateLimiter, RateFromCondDB
    • HltEvaluator, HltRoutingBitsWriter
    • HCRawBankDecoderHlt
    • RunChangeHandle
    • PreloadGeometryTool
  • dropping usage of UpdateManagerSvc in MDFReadingExample.py so that it's DD4hep compatible
  • dropping unused writeToXML feature of IUTReadoutTool
  • dropping unused hlt2 mode in HltConfigSvc
  • adding veloisClosed method to DeVP
  • merging RateFromTCK into GetLumiParameter
  • modernizing RateFromTCK (and made it DD4hep compliant)
  • fixing scope of compilation for Det/Magnet in DD4hep mode

Part of set of MRs Detector!292 (merged) !3789 (merged) Lbcom!629 (merged) Rec!3126 (merged) Boole!418 (merged) Allen!1021 (merged) Analysis!922 (merged) Moore!1806 (merged) Moore!1822 (merged) Alignment!316 (merged) Panoptes!186 (merged)

Edited Oct 14, 2022 by Sebastien Ponce
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: sponce_ITransportSvcsimplification