Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • Phys Phys
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 1
    • Issues 1
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • PhysPhys
  • Merge requests
  • !945

ThOr clean-ups

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alex Pearce requested to merge apearce-particle-functor-cleanup into master May 28, 2021
  • Overview 13
  • Commits 10
  • Pipelines 16
  • Changes 8
  • Particle combination objects now support the PT functor.
    • Allows for PT usage in combination cuts.
  • The combiner no longer evaluates the mother cut if the vertex fit fails.
    • The counter name now explicitly includes the vertex fit failure 'cut'.

Some breaking changes related to the combiner:

  • There is now a one-to-one correspondence between the Nth input container and the particles used for the Nth child.
    • There are N input properties named Input1, …, InputN.
  • There is no daughter/child cuts property as one can equivalently filter on the Nth input container.
  • The MotherCut property is now called CompositeCut.
  • The various CombXCut properties are now called CombinationXCut.
  • The combiner requires that identical particles in the decay descriptor are next to each other.
  • The combiner is more efficiency if 'rarer' particles are earlier in the decay descriptor.

For consistency the VertexCut property and InputX properties of the ThOr::Combiner (which acts on SOA objects) have been changed to reflect the names in the NBodyCombiner (which acts on AOS objects).

Requires Rec!2456 (merged). Required for Moore!862 (merged), DaVinci!550 (merged), and MooreAnalysis!39 (merged).

Edited Jun 28, 2021 by Alex Pearce
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: apearce-particle-functor-cleanup