Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • R Rec
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 268
    • Issues 268
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Jira
    • Jira
  • Merge requests 55
    • Merge requests 55
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • LHCbLHCb
  • Rec
  • Merge requests
  • !2456

ThOr functor clean-ups

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alex Pearce requested to merge apearce-particle-functor-cleanup into master May 28, 2021
  • Overview 29
  • Commits 10
  • Pipelines 8
  • Changes 9

Addresses a few rough edges found when rolling out ThOr functors to HLT2 lines:

  • The PT functor now supports ParticleCombination inputs, allowing to act like the APT LoKi functor.
  • The ETA, CHI2, and CHI2DOF GHOSTPROB, and MINIP functors now support LHCb::Particle input.
    • The CHI2DOF functor now works for both charged basic and composite objects, as the documentation states it should.
    • The TrChi2PerDoF implementation has been dropped as the CHI2DOF functor does the same thing.
  • The MASS functor has been redefined to act like the COMPOSITEMASS functor, which has now been dropped. MASS now acts like the M and AM LoKi functors.
    • The original MASS functor has become the MASSWITHHYPOTHESES functor. This isn't used in HLT2 yet but will be useful as a WMASS equivalent once support is added.

To-dos

  • A reasonable cut on the BPVLTIME functor removes all candidates; must be computing wrong.
    • Won't address here; see #204 (closed).

Required for Phys!945 (merged), Moore!862 (merged), DaVinci!550 (merged), and MooreAnalysis!39 (merged).

Edited Jun 28, 2021 by Alex Pearce
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: apearce-particle-functor-cleanup