Susumu Oda authored 4 years ago and Frank Winklmeier committed 4 years ago

Remove ATLAS_NO_CHECK_FILE_THREAD_SAFETY from SiHitIdHelper.h/cxx and TRTHitIdHelper.h/.cxx. Add const to static Si/TRTHitIdHelper helper. Add const to return type of Si/TRTHelper::GetHelper.

PyJobTransformsCore: Enable flake8 checking and fix code

See merge request atlas/athena!34168

CaloTrkMuIdTools: Fix memory leak in CaloMuonTag

See merge request atlas/athena!34250

InDetTruthAlgs+TRT_Digitization+InDetLowBetaFinder: cmake fixes

See merge request atlas/athena!34266

Protect against invalid detector elements in MDT decoding

Closes ATR-21606

See merge request atlas/athena!34253

Savanna Shaw authored 4 years ago and Frank Winklmeier committed 4 years ago

Adding some protection against invalid detector elements in the MDT decoding which arise when trying to access chambers that don't exist when running the NSW trigger test. Fixes ATR-21606.

MuonReadoutGeometry: Compile RpReadoutElement::fillCache() with optimization, even in debug builds.

See merge request atlas/athena!34276

Add plots divided by track author to InDetPhysValMonitoring

See merge request atlas/athena!34247

Add ATLAS_CHECK_THREAD_SAFETY to TRT_RawDataByteStreamCnv package

See merge request atlas/athena!34205

Remove ATLAS_NO_CHECK_FILE_THREAD_SAFETY from TRT_FillCablingData_DC3.h/cxx

See merge request atlas/athena!34278

PerfMonAna + PerfMonComps : Adding a script to dump tables from PerfMonMTSvc output JSON

See merge request atlas/athena!34118

Remove monitoring of DS1 chains

Closes ATR-21633

See merge request atlas/athena!34257

Remove ATLAS_NO_CHECK_FILE_THREAD_SAFETY from TRTDigSettings.h/cxx

See merge request atlas/athena!34279

Susumu Oda authored 4 years ago and Frank Winklmeier committed 4 years ago

Add missing ATLAS_CHECK_THREAD_SAFETY to TRT_Digitization package. Replace thread unsafe exit by return and replace std::cout by msg(MSG::FATAL) to notify the problem.

Preselect clusters with LUT in eflowRec track-cluster matching

See merge request atlas/athena!34246

Sweep: Adding strip charge cut in MM clusterization

See merge request atlas/athena!34135

TrkTrackSummaryTool+RingerSelectorTools+egammaAlgs: cmake fixes

See merge request atlas/athena!34267

TrigValTools: Python 3 fix

See merge request atlas/athena!34265

InDetVKalVxInJetTool+TrkVKalVrtFitter: Fix cppcheck warnings.

See merge request atlas/athena!34274

Write out the FS trigger vertices in to the EDM

See merge request atlas/athena!34193

Mark Sutton authored 4 years ago and Frank Winklmeier committed 4 years ago

The vertex collection produced in the fullscan jet tracking has been added to the EDM
so that it can be written out

TrkMaterialProvider: Fix cppcheck warnings.

See merge request atlas/athena!34272

TrigL2MuonSA: Fix another clang warning.

See merge request atlas/athena!34271

TrkV0Fitter: Fix cppcheck warnings.

See merge request atlas/athena!34275

LArCellRec: Fix for python 3 compatibility.

See merge request atlas/athena!34263

AthenaServices: Migrate from deprecated tbb::task.

See merge request atlas/athena!34268

Disable thread safety checker for unit test of InDetEtaDepenentCuts package

See merge request atlas/athena!34282

Add ATLAS_CHECK_THREAD_SAFETY to PixelToTPIDTool package

See merge request atlas/athena!34197

Susumu Oda authored 4 years ago and Frank Winklmeier committed 4 years ago

Add ATLAS_CHECK_THREAD_SAFETY to PixelToTPIDTool package to check and keep thread safety. Add ATLAS_NOT_THREAD_SAFE to PixeldEdxAODFix::execute because it uses const_cast.

CaloRingerTools: cmake fixes

See merge request atlas/athena!34269

PixelCalibAlgs: Fix cppcheck warnings.

See merge request atlas/athena!34273

JetRec: cmake fix

See merge request atlas/athena!34270

TrigConfData: Remove unused CxxUtils include

See merge request atlas/athena!34260

TrigEvent: CMake cleanup

See merge request atlas/athena!34181

Make code flake8/Py3 compliant. Delete unused `CVSutil` and
`CastorPreStager` module.

Modification to disable thread safety checker for the unit test of the InDetEtaDependentCuts pacakge

Remove ATLAS_NO_CHECK_FILE_THREAD_SAFETY from TRT_FillCablingData_DC3.h/cxx. Add ATLAS_NOT_THREAD_SAFE to defineTables and initialize of TRT_FillCablingData_DC3.

Add RpReadoutElement::fillCache() to the set of methods that are
compiled with optimization, even in debugging builds.  This method
makes heavy use of Eigen, which performs very poorly
in debug builds.

 - Pass large structures by const reference rather than by value.