Peter Onyisi authored 6 years ago and Vakhtang Tsulaia committed 6 years ago

Former-commit-id: 282d6a05

Fix test failures in master.



Former-commit-id: fed001d0

Former-commit-id: ff5a64e2

Former-commit-id: 6b28f423

Former-commit-id: f6ed62d2

Pavol Strizenec authored 6 years ago and Frank Winklmeier committed 6 years ago

Former-commit-id: 7447c689

Former-commit-id: 68a0f68d

Force the test to have a link dependency on libCaloRecLib; otherwise,
the linker will remove the dependency.  And if we don't link against
libCaloRecLib, then we can get ubsan errors related to
ConstDataVector<CaloCellCollection> because in that case, the typeinfo
for it won't get exported from the test binary.



Former-commit-id: 63aa95d4

Former-commit-id: fd78960e

The previous root workaround change causes a problem with clang, which
doesn't seem to properly implement __attribute__((used)) for destructors.
For clang, move the destructor completely out-of-line.  (Trying to remove
the destructor entirely resulted in a mysterious crash in TClass...).


Former-commit-id: d7d1674e

Walter Lampl authored 6 years ago and Frank Winklmeier committed 6 years ago

Former-commit-id: 13614764

The previous root workaround change causes a problem with clang, which
doesn't seem to properly implement __attribute__((used)) for destructors.
For clang, move the destructor completely out-of-line.  (Trying to remove
the destructor entirely resulted in a mysterious crash in TClass...).


Former-commit-id: 80682529

Former-commit-id: 9dc145fd

TileInfo is used to return any detector-dependent
constants or information regarding the Tile Calorimeter,
including conditions data via different conditions tools.
It is not good for AthenaMT.

So functionality of TileInfo which is provided via tools
will be removed and clients will be migrated to use tools directly.
It is supposed that TileInfo will keep and provide only constants
which will be initialized during initialization of job.

Migration of clients has been started.


Former-commit-id: a571f58e

clang warnings: Missing override keywords.


Former-commit-id: fad5d267

Walter Lampl authored 6 years ago and Adam Edward Barton committed 6 years ago

Former-commit-id: 0be0dd1a98c2e091004f23fc22610f16269379e8

Sanya Solodkov authored 6 years ago and Adam Edward Barton committed 6 years ago

Former-commit-id: c3df1d1c

Pavol Strizenec authored 6 years ago and Vakhtang Tsulaia committed 6 years ago

Former-commit-id: b026e443

Peter Onyisi authored 6 years ago and Vakhtang Tsulaia committed 6 years ago

Former-commit-id: d92d4bf0065df98232e7de86fe9f3216a0a02c63

Walter Lampl authored 6 years ago and Vakhtang Tsulaia committed 6 years ago

Former-commit-id: 1b83f6aa

Former-commit-id: 0abbaf5e

A test was failing due to a new INFO message from GeoModelSvc.
Suppress INFO messages from GeoModelSvc and update reference files.
Fixes test failure in master.



Former-commit-id: 80cd7e89

Former-commit-id: dcfc3cf6

TileBadChanTool tools was not declared as property
of CaloBadChanTool and it's dependencies was not propagated
up to CaloBadChanTool. This caused problems in AthenaMT
because this dependency was not propated to the algorithms
which use CaloBadChanTool. Now TileBadChanTool is declared
as property of CaloBadChanTool and made private.
The same is done also for LArBadChanTool because anyway
it should be made private at some moment.


Former-commit-id: 069ece00

Coverity warning: unchecked return values.


Former-commit-id: a82bac3c

Coverity warnings: uninitialized member; potential null pointer dereference.


Former-commit-id: 2f55b9c2

Former-commit-id: 366360c9

Scott Snyder authored 6 years ago and Frank Winklmeier committed 6 years ago

Former-commit-id: 6fdbfa13

Former-commit-id: 503def53

Former-commit-id: fbc95da7

Add a non-const version of CaloCellContainer::findCell.


Former-commit-id: f8d454b9058138549790759f14c0b5b2c3037605

fist step towards removing the offline-id accessors of LArElecCalib-classes. This commit removes the accssor for ILArAutoCorr, ILArDCA2UA, ILArMinBias, ILArMinBiasAverage, ILArMphysOverMcal, ILArNoise, ILArOFC, ILArPedestal, ILArRamp, ILArShape,ILArfSampl, ILAruA2MeV and adjusts teh following clients: CaloMBAverageTool, CaloNoiseTool LArCellBuilderFromLArHitTool and LArPileupTool. AFAIK, ony the LArPileupTool is actually used in production today.


Former-commit-id: 5b3d9326

remove explicilty locking of CellContainer (done by WriteHandle anyway). Retrieve CaloCell_ID helper in initialize instead of event loop


Former-commit-id: 2dec8c10

With root 6.14.04 and gcc8, cling is observed to sometimes crash when
handling a STL tree container.  Reported as ROOT-9709.
Work around by hiding this data member from cling.


Former-commit-id: 10e45279

clang warning: Unused private data member.


Former-commit-id: 6ac004a6

Former-commit-id: 82dd4f9f

In CaloCellPedestalCorr, it's possible to retrieve a null attribute list.
This was previously being ignored, but the last set of changes caused it
to crash again.  Alter the logic so that an empty list is ignored again.
Fixes crash in q220.



Former-commit-id: 78db6c81

Remove references to obsolete package CLIDSvc; header moved to AthenaKernel.
Also update references to headers in SGTools that were moved to AthenaKernel.



Former-commit-id: 4c5a3bff

Remove references to obsolete package CLIDSvc; header moved to AthenaKernel.
Also remove unneeded dependency on SGTools.



Former-commit-id: 238ad38194c862e93429b2779ecfe0df844a98b7

Remove references to obsolete package CLIDSvc; header moved to AthenaKernel.
Also remove unneeded dependency on SGTools.



Former-commit-id: d854368cdad22a6eee8d907be73ad2d23350fbc9